Tests: Fix _load_textdomain_just_in_time PHP Notice
#747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into fix-cron-tests
…er-encoding-form-insertion
…isibility-support-non-inline-forms # Conflicts: # .github/workflows/tests.yml
n7studios
requested review from
a team,
corydhmiller and
noelherrick
and removed request for
a team
… into fix-character-encoding-form-insertion
… into add-block-visibility-support-non-inline-forms
noelherrick
reviewed
Nov 25, 2024
Contributor
noelherrick
left a comment
noelherrick
left a comment
There was a problem hiding this comment.
Would this still catch errors in the Kit plugin if it made this mistake?
Contributor
Author
It only suppresses the We load our language files correctly by using the |
noelherrick
approved these changes
Nov 26, 2024
…ine-forms Block Visibility: Support non-inline Forms
Fix character encoding when inserting Form after specific HTML element
5 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WordPress 6.7 displays a PHP notice if a Theme or Plugin calls
load_plugin_textdomaintoo early i.e. before the WordPressinithook and WP_DEBUG is enabled.This Plugin's tests run with WP_DEBUG enabled, and due to activating third party Plugins to run specific tests against, we get errors:
This PR resolves by suppressing the
_load_textdomain_just_in_timePHP notice in our automated testing via use of a Plugin, whilst allowing other notices to still display and be detected.Also fixes cron tests failing due to a change in the admin UI URL in WP Crontrol 1.17.1, released November 23rd.
Testing
Existing tests pass.
Checklist