fix: remove repeating sound when using pseudo-pause on repentance+ #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
can you do the PR to the repentance+ branch? |
Member
|
actually nevermind |
Zamiell
force-pushed
the
repplus-sound-glitch
branch
2 times, most recently
from
1144ad1 to
a997387
Compare
Zamiell
force-pushed
the
repplus-sound-glitch
branch
from
7aafa02 to
78911c5
Compare
Member
|
published in 87.8.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pause item now plays a sound effect when the item is activated in Repentance+. Due to the pseudo-pause functionality relying on repeatedly activating the Pause item, this causes the sound to trigger repeatedly. I investigated some other ways to handle properly achieving a pseudo-pause system without relying on the active item (though there were always edge cases in each scenario); so instead added the following fix to just stop playing the sound immediately after triggering the Pause active item.