FEAT: Add new VAT number validator #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivervogel
requested changes
Dec 28, 2025
Member
olivervogel
left a comment
olivervogel
left a comment
There was a problem hiding this comment.
Thank you very much. I have two change requests. Otherwise, it's a good idea and implementation.
olivervogel
requested changes
Dec 29, 2025
Member
olivervogel
left a comment
olivervogel
left a comment
There was a problem hiding this comment.
Thank you. I noticed one last thing.
| yield [true, 'CHE123456789TVA']; | ||
| yield [true, 'CHE123456789IVA']; | ||
| yield [true, 'CH123456']; | ||
| yield [true, ' de123456789 ']; |
Member
There was a problem hiding this comment.
Suggested change
| yield [true, ' de123456789 ']; | |
| yield [false, ' de123456789 ']; |
Member
There was a problem hiding this comment.
This matches the behaviour of the other rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new validation rules for a European VAT number.
Its is only validating the format and not for existence