Improve linspace implementation with non-scalar inputs
#2712
+167
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_56 ran successfully. |
Collaborator
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
antonwolfy
force-pushed
the
resolve-gh-2084
branch
4 times, most recently
from
ecb9ddf to
019d7dd
Compare
antonwolfy
force-pushed
the
resolve-gh-2084
branch
from
7ca6821 to
37aa4d1
Compare
with an integer dtype
dpnp/tests/third_party/cupy/creation_tests/test_ranges.py scope. The issue seems visible when calculations are don with float32 dtype. The issue might be caused by dpctl-2230 and needs to be reconsidered later.
antonwolfy
force-pushed
the
resolve-gh-2084
branch
2 times, most recently
from
2c9446c to
ab8136d
Compare
vlad-perevezentsev
approved these changes
Jan 16, 2026
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM!
Just one minor comment :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes #2084.
This PR improves implementation of
dpnp.linspacefunction aligning it with the latest changes added to NumPy.The tests coverage is also extended to verify more use cases.