feat: Stop use FilePicker on BugTracker #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baillyjamy
force-pushed
the
remove-filepicker-from-legacy-bugtracker
branch
from
aaac29b to
1f3424f
Compare
baillyjamy
force-pushed
the
move-extension-utils-from-legacy
branch
from
21d8495 to
2b5d0ea
Compare
baillyjamy
force-pushed
the
remove-filepicker-from-legacy-bugtracker
branch
2 times, most recently
from
21a0899 to
71d0b11
Compare
FabianDevel
requested changes
Jan 21, 2026
Contributor
There was a problem hiding this comment.
Why did you changed the logic here instead of putting the filePicker in new Core ?
Is it because the FilePicker class isn't really useful ?
Because FilePicker is used at several other places, it should be probably updated accordingly
EDIT: It is because the class wasn't useful, so we'll just remove it when decommissioning legacy core
Ui/View/src/main/kotlin/com/infomaniak/core/ui/view/MaterialButtonExtensions.kt
Outdated
Show resolved
Hide resolved
baillyjamy
force-pushed
the
move-extension-utils-from-legacy
branch
from
84e5811 to
0ba3806
Compare
baillyjamy
force-pushed
the
remove-filepicker-from-legacy-bugtracker
branch
from
71d0b11 to
885bb50
Compare
FabianDevel
approved these changes
Jan 22, 2026
baillyjamy
force-pushed
the
move-extension-utils-from-legacy
branch
from
0ba3806 to
c697ac8
Compare
baillyjamy
force-pushed
the
remove-filepicker-from-legacy-bugtracker
branch
from
885bb50 to
5e21ed6
Compare
|
Base automatically changed from
move-extension-utils-from-legacy
to
feat/move-bug-tracker
January 22, 2026 15:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second step to move bugtracker from legacy to core