feat(CrossAppLogin): Add UI #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Will review next week. |
baillyjamy
force-pushed
the
feat-crossapplogin
branch
3 times, most recently
from
397902d to
4d22a56
Compare
baillyjamy
force-pushed
the
feat-onboarding
branch
from
5ea9118 to
d3c0a40
Compare
baillyjamy
force-pushed
the
feat-crossapplogin
branch
from
4d22a56 to
0ee1b2e
Compare
Contributor
Author
|
I didn't add the screen header because it's not final on figma. @LunarX |
baillyjamy
force-pushed
the
feat-crossapplogin
branch
from
edcf427 to
e59bf90
Compare
LouisCAD
approved these changes
Jan 21, 2026
Contributor
LouisCAD
left a comment
LouisCAD
left a comment
There was a problem hiding this comment.
Looking good. A few things regarding todo comments.
app/src/main/kotlin/com/infomaniak/auth/manager/AccountsManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/infomaniak/auth/ui/screen/onboarding/OnboardingScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/infomaniak/auth/ui/screen/onboarding/OnboardingScreen.kt
Outdated
Show resolved
Hide resolved
baillyjamy
force-pushed
the
feat-crossapplogin
branch
2 times, most recently
from
5f906ec to
c89e35c
Compare
baillyjamy
force-pushed
the
feat-crossapplogin
branch
from
c89e35c to
6eb48e4
Compare
LunarX
reviewed
Jan 21, 2026
app/src/main/kotlin/com/infomaniak/auth/ui/navigation/NavigationEntryProvider.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/infomaniak/auth/ui/navigation/NavigationEntryProvider.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/infomaniak/auth/ui/screen/onboarding/OnboardingScreen.kt
Outdated
Show resolved
Hide resolved
LunarX
approved these changes
Jan 22, 2026
LouisCAD
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add crossapplogin with getting account.
Keep lot of todo until login logic not ready