Skip to content

Conversation

@RivaIvanova
Copy link
Member

Closes #16288

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@RivaIvanova RivaIvanova requested review from ChronosSF and removed request for gedinakova October 13, 2025 08:01
@ChronosSF ChronosSF requested a review from Copilot October 20, 2025 06:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where shared tooltips weren't properly closing when hovering over another target, addressing issue #16288. The fix ensures that when a single tooltip is used across multiple targets, it immediately closes for the previous target when hovering over a new one.

Key changes:

  • Refactored the stopAnimations method to remove the force parameter and simplified its functionality
  • Added a new forceClose method to handle immediate tooltip closure with proper animation handling
  • Updated the tooltip target directive to use the new forceClose method instead of stopAnimations

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tooltip.directive.ts Refactored animation handling and added forceClose method for immediate tooltip closure
tooltip-target.directive.ts Updated to use forceClose method when switching between targets
tooltip.directive.spec.ts Added test case for tooltip positioning when no close animation is present

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MonikaKirkova MonikaKirkova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Oct 21, 2025
@kacheshmarova kacheshmarova merged commit 525cdb9 into 20.1.x Oct 23, 2025
6 checks passed
@kacheshmarova kacheshmarova deleted the rivanova/fix-16288-20.1.x branch October 23, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooltip version: 20.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Shared tooltip does not open/close properly when having openAnimation/closeAnimation set to undefined

5 participants