-
Notifications
You must be signed in to change notification settings - Fork 160
fix(tooltip): force close shared tooltip when hovering another target - 20.1.x #16291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where shared tooltips weren't properly closing when hovering over another target, addressing issue #16288. The fix ensures that when a single tooltip is used across multiple targets, it immediately closes for the previous target when hovering over a new one.
Key changes:
- Refactored the
stopAnimationsmethod to remove the force parameter and simplified its functionality - Added a new
forceClosemethod to handle immediate tooltip closure with proper animation handling - Updated the tooltip target directive to use the new
forceClosemethod instead ofstopAnimations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tooltip.directive.ts | Refactored animation handling and added forceClose method for immediate tooltip closure |
| tooltip-target.directive.ts | Updated to use forceClose method when switching between targets |
| tooltip.directive.spec.ts | Added test case for tooltip positioning when no close animation is present |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Closes #16288
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)