-
Notifications
You must be signed in to change notification settings - Fork 39
Fix styling of strapline on homepage #4639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix styling of strapline on homepage #4639
Conversation
hypha/home/templates/home/home.html
Outdated
|
|
||
| {% if settings.core.SystemSettings.home_strapline %} | ||
| <p class="mb-8 text-fg-muted text-pretty">{{ settings.core.SystemSettings.home_strapline|nh3|safe }}</p> | ||
| <div class="strapline">{{ settings.core.SystemSettings.home_strapline|nh3|safe }}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test with adding the "prose" class instead of the styles in strapline.css?
<div class="mb-8 text-fg-muted text-pretty prose">{{ settings.core.SystemSettings.home_strapline|nh3|safe }}</div>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently I could use the prose-a:text-primary class to add styling to the links inside the strapline. Would you be open that that change too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an extra commit ✅

Fixes #4634
Screenshots
Before
After