Skip to content

Fixing Issues When Importing SVGs with Gradients #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KartikSharma0 wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fixing Issues When Importing SVGs with Gradients #3602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbbcee1
fix: implementing radial gradients correctly
KartikSharma0 Jan 7, 2026
1a457bc
Merge branch 'master' into fix-importing-svg-gradients-2524
KartikSharma0 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,13 @@ fn apply_usvg_fill(fill: &usvg::Fill, modify_inputs: &mut ModifyInputsContext, t
})
}
usvg::Paint::RadialGradient(radial) => {
let local = [DVec2::new(radial.cx() as f64, radial.cy() as f64), DVec2::new(radial.fx() as f64, radial.fy() as f64)];
let center = DVec2::new(radial.cx() as f64, radial.cy() as f64);
let focal = DVec2::new(radial.fx() as f64, radial.fy() as f64);
let radius = radial.r().get() as f64;

let direction = if center != focal { (center - focal).normalize() } else { DVec2::X };

let edge = focal + direction * radius;

// TODO: fix this
// let to_doc_transform = if radial.base.units == usvg::Units::UserSpaceOnUse {
Expand All @@ -473,7 +479,7 @@ fn apply_usvg_fill(fill: &usvg::Fill, modify_inputs: &mut ModifyInputsContext, t
let to_doc_transform = transform;
let to_doc = to_doc_transform * usvg_transform(radial.transform());

let document = [to_doc.transform_point2(local[0]), to_doc.transform_point2(local[1])];
let document = [to_doc.transform_point2(focal), to_doc.transform_point2(edge)];
let layer = [transform.inverse().transform_point2(document[0]), transform.inverse().transform_point2(document[1])];

let [start, end] = [bounds_transform.inverse().transform_point2(layer[0]), bounds_transform.inverse().transform_point2(layer[1])];
Expand Down