Skip to content

Conversation

@th-94
Copy link
Collaborator

@th-94 th-94 commented Oct 15, 2025

📖 Description

Ship custom elements manifest in the library

#445

✏️ Type of change

Please delete options that are not relevant.
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🧪 How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

✅ Checklist:

  • My code follows the SGDS style guidelines and naming conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@th-94 th-94 requested review from amandac628 and clukhei October 15, 2025 05:48
exclude: ['**/*.scss', 'src/utils/'],
globs: ["src/**/sgds-*.ts", "src/**/*-element.ts"],
exclude: ["**/*.scss", "src/utils/"],
outdir: "lib",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, i realise if u outdir in "lib" means it won't appear in root anymore? Will this be ok for storybook building?

i think u need to try delete your custom-elements.json in root to try out, cause yesterday it might be reading from the outdated file in the root?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.storybook/preview.ts is using root level custom-element.json

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, let me test it out and fix again, thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw the new PR on fouc will be using root level ce too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but im also ok if all read from lib/custom-elements.json
as long as the final custom elements.json is the most updated one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants