-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove post-startup-script key from protected metadata for EUC #15998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Removed unnecessary metadata keys from the template.
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Added WorkbenchInstanceEUCSettableUnmodifiableDefaultMetadata for additional metadata handling.
| } | ||
|
|
||
| for _, metadata := range WorkbenchInstanceEUCSettableUnmodifiableDefaultMetadata { | ||
| if strings.Contains(k, metadata) && new == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did a complete match for WorkbenchInstanceEUCProvidedAdditionalMetadata but are doing a substring match here- could you elaborate on why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just for consistency with the existing WorkbenchInstanceSettableUnmodifiableDefaultMetadata check, changed it to a complete match.
|
|
||
| for _, key := range WorkbenchInstanceSettableUnmodifiableDefaultMetadata { | ||
| unmodifiableKeys := append([]string{}, WorkbenchInstanceSettableUnmodifiableDefaultMetadata...) | ||
| if v, ok := diff.GetOk("enable_managed_euc"); ok && v.(bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: tabs instead of spaces (sorry! IDEs don't handle these template files the best)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 25 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
|
/gcbrun |
Removed comment about EUC-specific logic in test.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.