Skip to content

Conversation

@madhusuraj
Copy link
Contributor

@madhusuraj madhusuraj commented Dec 18, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: support setting post-startup script metadata keys with managed EUC for `google_workbench_instance`

Removed unnecessary metadata keys from the template.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 18, 2025
@github-actions github-actions bot requested a review from rileykarson December 18, 2025 23:08
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Added WorkbenchInstanceEUCSettableUnmodifiableDefaultMetadata for additional metadata handling.
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 19, 2025
}

for _, metadata := range WorkbenchInstanceEUCSettableUnmodifiableDefaultMetadata {
if strings.Contains(k, metadata) && new == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did a complete match for WorkbenchInstanceEUCProvidedAdditionalMetadata but are doing a substring match here- could you elaborate on why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just for consistency with the existing WorkbenchInstanceSettableUnmodifiableDefaultMetadata check, changed it to a complete match.


for _, key := range WorkbenchInstanceSettableUnmodifiableDefaultMetadata {
unmodifiableKeys := append([]string{}, WorkbenchInstanceSettableUnmodifiableDefaultMetadata...)
if v, ok := diff.GetOk("enable_managed_euc"); ok && v.(bool) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: tabs instead of spaces (sorry! IDEs don't handle these template files the best)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 17 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 17 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 34 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • workbench

🟢 All tests passed!

View the build log

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 20, 2025
@github-actions github-actions bot requested a review from rileykarson December 20, 2025 00:53
@github-actions
Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@madhusuraj
Copy link
Contributor Author

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/notebooks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants