-
Notifications
You must be signed in to change notification settings - Fork 2
Fix/UI issues #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Fix/UI issues #290
Conversation
…b-Front into fix/ui_issues
| const margin = 60 | ||
| const radius = 80 | ||
| if (isRightish) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ne faudrait-il pas faire la meme chose en Y si la carte sort du viewport en haut ou en bas ?
| export const useDataStore = defineStore("data", () => { | ||
| const viewerStore = useViewerStore() | ||
|
|
||
| const itemCache = new Map() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pk tu as besoin d'ajouter ca ?
| const geodeStore = this | ||
| const feedbackStore = useFeedbackStore() | ||
| return useFetch(back_schemas.opengeodeweb_back.ping.$id, { | ||
| return $fetch(back_schemas.opengeodeweb_back.ping.$id, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pk ce changement ?
@JulienChampagnol tu mentionnais des trucs sur useFetch vs $fetch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y a un warning de nuxt quand on utilise useFetch et que le composant est mounted, il dit 'use $fetch instead', car useFetch est un composable
| feedbackStore.$patch({ server_error: true }) | ||
| geodeStore.status = Status.NOT_CONNECTED | ||
| }, | ||
| }).catch((error) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JulienChampagnol un avis sur le changement de gestion d'erreur ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y a pas de onRequestError dans $fetch ? Ce serait mieux si on garde ça
| { immediate: true }, | ||
| ) | ||
| } else { | ||
| meta_data.value = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Déjà le cas ?
| } | ||
| </script> | ||
|
|
||
| <style scoped> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Baeucoup de chose là dedans, je ne doute pas que ça fonctionne mais c'est assez difficile à lire
| const geodeStore = this | ||
| const feedbackStore = useFeedbackStore() | ||
| return useFetch(back_schemas.opengeodeweb_back.ping.$id, { | ||
| return $fetch(back_schemas.opengeodeweb_back.ping.$id, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y a un warning de nuxt quand on utilise useFetch et que le composant est mounted, il dit 'use $fetch instead', car useFetch est un composable
| feedbackStore.$patch({ server_error: true }) | ||
| geodeStore.status = Status.NOT_CONNECTED | ||
| }, | ||
| }).catch((error) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y a pas de onRequestError dans $fetch ? Ce serait mieux si on garde ça
No description provided.