Skip to content

Conversation

@tier940
Copy link
Member

@tier940 tier940 commented Jan 20, 2026

No description provided.

@tier940 tier940 self-assigned this Jan 20, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tier940, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive integration with the "Just Enough Resources" (JER) mod, aiming to provide players with enhanced in-game information about item drops. A new gameplay feature has been added, enabling certain hostile mobs to drop their skulls upon player defeat. The implementation of these skull drops is handled through modifications to the game's loot tables, which also ensures their visibility and accurate representation within the JER interface. The PR also includes necessary build system updates and internal mod registration to support the new integration.

Highlights

  • Just Enough Resources (JER) Integration: The project now fully integrates the "Just Enough Resources" mod, allowing players to view detailed information about item drops and resources.
  • New Mob Skull Drop Mechanic: Introduced a feature where Creepers, Skeletons, Zombies, and Endermen (when EnderIO is present) have a 2.5% chance to drop their respective skulls when killed by a player.
  • Loot Table Modifications for JER Display: Entity loot tables for relevant mobs have been updated to include the new skull drops, ensuring they are correctly displayed within the JER interface.
  • Build System and Mod Registration: Updated Gradle dependencies to include JER and added a dedicated debug flag, along with registering JER in the internal Mods utility and as a core module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストは、Just Enough Resources (JER) との連携機能を追加するものです。全体的に良い変更ですが、いくつかの改善点があります。
主な懸念点は、GTEEventHandlersJERModule の両方でモブの頭蓋骨ドロップ処理が実装されており、機能が重複している点です。これにより、意図しない二重ドロップの可能性があります。LootTableLoadEvent を使用する JERModule の実装がよりモダンで互換性が高いため、GTEEventHandlersLivingDropsEvent に基づく実装は削除することを推奨します。
また、JERModule.java 内のコードの重複を減らすためのリファクタリングと、dependencies.gradle の依存関係定義をより保守しやすくするための提案も行いました。
これらの点を修正することで、コードの品質と保守性が向上します。

@tier940 tier940 changed the title Add JER Integration Add Mob Head drop Jan 20, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストは、特定のMobが倒された際に頭をドロップする機能を追加するものです。変更は主に GTEEventHandlers.java に集中しており、Loot Tableを操作してドロップを追加しています。コードは機能的に正しいように見えますが、保守性と可読性を向上させるためにいくつかのリファクタリングが可能です。特に、コードの重複を減らし、マジックナンバーを定数に置き換えることを提案します。詳細は各コメントを参照してください。

@tier940 tier940 merged commit e44ff97 into master Jan 20, 2026
2 checks passed
@tier940 tier940 deleted the tier-add-integration-jer branch January 20, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants