Skip to content

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Jan 22, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Corrected CSS syntax error in styling framework.
  • Style

    • Enhanced split layout component with improved overflow handling for better display and scrolling behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Walkthrough

The change adds CSS styling support to the SplitLayoutDemo component by assigning a CSS class name in the Java constructor and adding corresponding CSS rules to control overflow behavior, while simultaneously fixing a stray closing brace in the stylesheet.

Changes

Cohort / File(s) Summary
Component Styling
src/main/java/com/flowingcode/vaadin/addons/demo/SplitLayoutDemo.java
Added setClassName("commons-demo-split-layout") call in constructor to assign CSS class (+1)
CSS Styling and Fixes
src/main/resources/META-INF/resources/frontend/styles/commons-demo/shared-styles.css
Removed stray closing brace after .helper-button block; added new .commons-demo-split-layout { overflow: hidden } and .commons-demo-split-layout > [slot] { overflow: auto } rules (+4/-1)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main change: fixing layout scroll behavior in Vaadin 25 by adding CSS class assignment and related styles.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@javier-godoy javier-godoy requested a review from paodb January 22, 2026 16:25
@javier-godoy javier-godoy marked this pull request as ready for review January 22, 2026 16:26
@paodb paodb merged commit b4517d7 into master Jan 22, 2026
3 checks passed
@paodb paodb deleted the 20260122-01 branch January 22, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants