Skip to content

Conversation

@matthewelwell
Copy link
Contributor

Changes

Fixes syntax error in ECS deployment as seen here.

How did you test this code?

Ran the workflow (with the actual deployment steps removed) - see here. Note that we only care that the job actually ran as that confirms the syntax error is resolved.

@matthewelwell matthewelwell requested a review from a team as a code owner January 22, 2026 12:18
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team January 22, 2026 12:18
@vercel
Copy link

vercel bot commented Jan 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Review Updated (UTC)
docs Ignored Ignored Jan 22, 2026 0:18am
flagsmith-frontend-preview Ignored Ignored Jan 22, 2026 0:18am
flagsmith-frontend-staging Ignored Ignored Jan 22, 2026 0:18am

Request Review

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the ci-cd Build, test and deployment related label Jan 22, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6576 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6576 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6576 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6576 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6576 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6576 Finished ✅ Results

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.16%. Comparing base (0d956a5) to head (c5617fa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6576   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files        1295     1295           
  Lines       46793    46793           
=======================================
  Hits        45934    45934           
  Misses        859      859           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewelwell matthewelwell merged commit ff93347 into main Jan 22, 2026
32 checks passed
@matthewelwell matthewelwell deleted the ci/fix-workflow-syntax branch January 22, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Build, test and deployment related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants