Skip to content

Conversation

@Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Jan 20, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Calculation of the segment overrides (in v1) was counting unique segment ids. Leading to situations where you could have 10 segments and unlimited overrides.

  • Calculate the limit based on all features states and not distinct segment ids

How did you test this code?

  • Added tests, including non-regression tests for v2 extra count

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner January 20, 2026 09:32
@Zaimwa9 Zaimwa9 requested review from gagantrivedi and removed request for a team January 20, 2026 09:32
@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 21, 2026 11:47am
flagsmith-frontend-preview Ready Ready Preview, Comment Jan 21, 2026 11:47am
flagsmith-frontend-staging Ready Ready Preview, Comment Jan 21, 2026 11:47am

Request Review

@github-actions github-actions bot added api Issue related to the REST API fix labels Jan 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6555 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-6555 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6555 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6555 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6555 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6555 Finished ✅ Results

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.15%. Comparing base (e491580) to head (f328064).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6555   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files        1293     1293           
  Lines       46610    46642   +32     
=======================================
+ Hits        45751    45783   +32     
  Misses        859      859           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants