-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Show the csv icon when a report is exported via export template #78529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppThe custom column isn’t available on small devices. Android: mWeb ChromeThe custom column isn’t available on small devices. iOS: HybridAppThe custom column isn’t available on small devices. iOS: mWeb SafariThe custom column isn’t available on small devices. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/nkuoch in version: 9.2.91-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.91-1 🚀
|

Explanation of Change
Adds the export icon (document icon) when a report is exported via All Data - Expense level or All Data - Report Level
Fixed Issues
$ #78226
Tests
Create an expense
Open it, export it via export > all data - expense level
Go back to the expenses page
Select columns -> exported to
Ensure that the 'Document' icon shows up
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari