fix: Receipt is zoomed in and cropped when rotating the receipt #78497

nkdengineer · 2025-12-28T09:56:20Z

Explanation of Change

fix: Receipt is zoomed in and cropped when rotating the receipt

Fixed Issues

$ #78368
PROPOSAL:

Tests

Tap on FAB > Scan
Upload a tall image
Click on the receipt thumbnail
Click on the rotate icon
Verify that the image size is changed accordingly

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-28.at.16.44.06.mov

Android: mWeb Chrome

Screen.Recording.2025-12-28.at.16.50.05.mov

iOS: Native

Screen.Recording.2025-12-28.at.16.48.51.mov

iOS: mWeb Safari

Screen.Recording.2025-12-28.at.16.47.22.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-28.at.16.50.28.mov

melvin-bot · 2025-12-28T10:04:53Z

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-28T10:04:56Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Lightbox/index.tsx	`64.70% <100.00%> (+2.20%)`	⬆️
src/components/Image/BaseImage.android.tsx	`0.00% <0.00%> (ø)`
... and 4 files with indirect coverage changes

aimane-chnaif · 2025-12-29T07:33:40Z

src/components/Image/BaseImage.android.tsx

+    // Reset isLoadedRef when source changes to allow onLoad to fire again for new images (e.g., after rotation)
+    useEffect(() => {
+        isLoadedRef.current = false;
+    }, [source]);


add line break

aimane-chnaif · 2025-12-29T07:59:09Z

src/components/Lightbox/index.tsx

+    useEffect(() => {
+        // Clear the content size state to force recalculation of dimensions
+        // This ensures that when an image is rotated and gets a new URI,
+        // we don't use stale cached dimensions from the previous image
+        setInternalContentSize(undefined);
+        setLightboxImageLoaded(false);
+        setFallbackImageLoaded(false);
+        setIsLoading(true);
+        // Don't delete from cache here as other components might still need it
+        // The new URI will get its own cache entry when loaded
+    }, [uri]);


Can we run this effect only when uri is changed?
This also runs on mount and contentSize is overridden by setInternalContentSize(undefined); so it doesn't get benefit of cached image here:

App/src/components/Lightbox/index.tsx

Line 114 in 9e3ecbb

const [contentSize, setInternalContentSize] = useState<Dimensions | undefined>(() => cachedImageDimensions.get(uri));

Yes, i agree with @aimane-chnaif, this cannot run like this on mount. Other than that, this change looks good to me

@aimane-chnaif I updated.

aimane-chnaif · 2025-12-29T08:01:12Z

@chrispader does this change make sense to you? Sorry but tagging you since you worked/refactored on image components.

This PR is fixing this:

The RCA is the LightBox cached the image size, but it's not reset when the URI is changed.

chrispader · 2026-01-01T11:40:52Z

@chrispader does this change make sense to you? Sorry but tagging you since you worked/refactored on image components.

This PR is fixing this:

The RCA is the LightBox cached the image size, but it's not reset when the URI is changed.

@aimane-chnaif i think this change makes sense to me. We just got to make sure to not loose cached image dimensions for other instances of the Lightbox component

fix: Receipt is zoomed in and cropped when rotating the receipt

214030e

melvin-bot bot assigned nkdengineer Dec 28, 2025

nkdengineer marked this pull request as ready for review December 28, 2025 10:04

nkdengineer requested review from a team as code owners December 28, 2025 10:04

melvin-bot bot requested review from linhvovan29546 and removed request for a team December 28, 2025 10:04

aimane-chnaif reviewed Dec 29, 2025

View reviewed changes

nkdengineer added 3 commits January 6, 2026 01:16

Merge branch 'main' into fix/78368

420e065

Merge branch 'main' into fix/78368

5e098ee

prevent the logic run on mount

22aea2d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Receipt is zoomed in and cropped when rotating the receipt #78497

fix: Receipt is zoomed in and cropped when rotating the receipt #78497

nkdengineer commented Dec 28, 2025

Uh oh!

melvin-bot bot commented Dec 28, 2025

Uh oh!

codecov bot commented Dec 28, 2025 •

edited by github-actions bot

Loading

Uh oh!

aimane-chnaif Dec 29, 2025

Uh oh!

aimane-chnaif Dec 29, 2025

Uh oh!

chrispader Jan 1, 2026

Uh oh!

nkdengineer Jan 5, 2026

Uh oh!

aimane-chnaif commented Dec 29, 2025 •

edited

Loading

Uh oh!

chrispader commented Jan 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: Receipt is zoomed in and cropped when rotating the receipt #78497

Are you sure you want to change the base?

fix: Receipt is zoomed in and cropped when rotating the receipt #78497

Conversation

nkdengineer commented Dec 28, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 28, 2025

Uh oh!

codecov bot commented Dec 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aimane-chnaif Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

chrispader Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

nkdengineer Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrispader commented Jan 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Dec 28, 2025 •

edited by github-actions bot

Loading

aimane-chnaif commented Dec 29, 2025 •

edited

Loading