-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix/78099: Fix spacing between merchant and input #78491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
btkcodedev
wants to merge
1
commit into
Expensify:main
Choose a base branch
from
btkcodedev:btkcodedev/78099SpacingMerchantvsPercent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix/78099: Fix spacing between merchant and input #78491
btkcodedev
wants to merge
1
commit into
Expensify:main
from
btkcodedev:btkcodedev/78099SpacingMerchantvsPercent
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb Chrome |
Pujan92
approved these changes
Dec 30, 2025
Contributor
Pujan92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Author
|
@flodnv Awaiting your review🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Explanation of Change
Adding margin to the component container style will fix the spacing issue
Fixed Issues
$ #78099
PROPOSAL: #78099 (comment)
Tests
Offline tests
Same as above
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_20251227_190703_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20251227_165037_Brave.mp4
iOS: Native
Screen.Recording.2025-12-27.at.7.10.12.PM.mov
iOS: mWeb Safari
Screen.Recording.2025-12-27.at.7.12.31.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-19.at.10.48.10.PM.mov