Create dotnet.yml #2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
.github/workflows/dotnet.yml
Outdated
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
[P1] Run WPF build on Windows runner
The workflow is configured to run on ubuntu-latest, but msOps.csproj targets net9.0-windows with UseWPF=true, which requires Windows tooling. A WPF build can’t restore or compile on Linux agents, so this job will fail on every run until the runner is switched to windows-latest (or another Windows image).
Useful? React with 👍 / 👎.
.github/workflows/dotnet.yml
Outdated
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: 8.0.x |
There was a problem hiding this comment.
[P1] Install .NET 9 SDK to match project target
The setup step installs only the 8.0 SDK, but the project targets net9.0-windows; without a 9.0 SDK the subsequent dotnet restore/build will fail with NETSDK1207 because the target framework isn’t available. Update dotnet-version (or add a global.json) so the workflow installs a 9.0 SDK.
Useful? React with 👍 / 👎.
No description provided.