Askrene: scale with many layers #8760
Open
+51
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple bench. Before: Creating 20,000 layers: 32 seconds After: Creating 20,000 layers: 13 seconds Creating 50,000 layers: 30 seconds Creating 100,000 layers: 57 seconds Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…ers on startup. We used non-persistent layers before, but what if we save to the datastore and restore? This takes it from 57 to 87 seconds. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Collaborator
|
Nice. I would like to see a benchmark to measure the time we spend fetching layers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Lagrang3 pointed out that our single linked list of layers will become a bottleneck, so this contains a quick benchmark for many layers, and replaces the linked list with a hashtable.
Changelog-None