Fix remote local timeline filter switching from sidebar #2415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
local/federated/trendingusing the toolbar menu because the tab was created with a constantTimelineFilterbinding.Description
TimelineTab(timeline: .constant(filter))for.anyTimelineFilterwith a small wrapper viewTimelineFilterTabthat owns a@State private var timelineinitialized with the provided filter.TimelineFilterTabexposes a binding to the internaltimelineand forwards it toTimelineTabviaTimelineTab(timeline: $timeline)so toolbar changes mutate the tab state.IceCubesApp/App/Tabs/Tabs.swiftand adds the privateTimelineFilterTabstruct.Testing
Codex Task