Skip to content

Conversation

@tpoliaw
Copy link
Collaborator

@tpoliaw tpoliaw commented Dec 2, 2024

and implement locking in memory instead of relying on filesystem.
Still won't protect against files being modified by external processes
but simplifies preventing two requests interfering.

Fixes #5

@tpoliaw tpoliaw marked this pull request as draft December 2, 2024 16:38
tpoliaw and others added 5 commits December 4, 2024 10:37
and implement locking in memory instead of relying on filesystem.
Still won't protect against files being modified by external processes
but simplifies preventing two requests interfering.
@tpoliaw tpoliaw marked this pull request as ready for review December 4, 2024 11:00
@tpoliaw
Copy link
Collaborator Author

tpoliaw commented Dec 4, 2024

Fixes #5

@callumforrester
Copy link
Contributor

@tpoliaw you need to put you "Fixes" in the PR description for it to automatically close #5

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpoliaw tpoliaw merged commit 1b9f83c into main Dec 10, 2024
3 checks passed
@tpoliaw tpoliaw deleted the ext_dir_locking branch December 10, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign directory fallback system

3 participants