Skip to content

Conversation

@oliwenmandiamond
Copy link
Contributor

@oliwenmandiamond oliwenmandiamond commented Dec 17, 2025

Fixes #1615

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.12%. Comparing base (5955929) to head (8a7f4f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1795   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         282      283    +1     
  Lines       10698    10774   +76     
=======================================
+ Hits        10604    10680   +76     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oliwenmandiamond oliwenmandiamond marked this pull request as ready for review January 5, 2026 10:44
@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner January 5, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GenericShutter is added to AbstractEnergySource, EnergySource and DualEnergySource devices

2 participants