-
Notifications
You must be signed in to change notification settings - Fork 8
WIP User client #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP User client #1323
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
+ Coverage 94.76% 94.90% +0.13%
==========================================
Files 42 42
Lines 2752 2866 +114
==========================================
+ Hits 2608 2720 +112
- Misses 144 146 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Some initial thoughts without having looked into it too much:
|
|
Thanks for looking at it. You're right, it needs a lot more docs but I wanted to wait to check the interface was vaguely right before writing it up. I'll add something to the PR for now.
The The
Not a bad idea but all the |
Using the find_device method instead of looking devices up in the map of devices directly means child devices can be found, eg 'stage.x' could be a valid device but isn't in the devices map in its own right.
Allows autocomplete to work when working in a REPL
* Support args as well as kwargs when running plans * Get child devices via attributes on parent devices * Make more methods into properties
For some reason pyright can't figure out what the return type is otherwise and you don't get completion.
It broke type checking
Implementation of a simple user client following discussion in #1284