-
Notifications
You must be signed in to change notification settings - Fork 6
Add Rest API Backend #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 86.10% 86.74% +0.63%
==========================================
Files 23 25 +2
Lines 979 1056 +77
==========================================
+ Hits 843 916 +73
- Misses 136 140 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
0c01945 to
59f76b5
Compare
0d9843d to
0790c73
Compare
GDYendell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few comments.
I assume the test utilities have just been copied from the tango PR for now and most of it can be shared between backends once merged?
Thank you for the review Gary. I found a few tricks when I did the web api testing and fed this back into Tango. Since we will add p4p I did not look at softioc... |
|
@GDYendell Updated the testing inline with feedback from #66 |
An additional "backend" for FastCS which provides a RestAPI.
The API is fully discoverable and demoable from the autogenerated "Swagger gui" at "{domain}/docs" and the schema can be retrived from "{domain}/openapi.json", all thanks to FastAPI.
The following considersations have been taken to conform with restful design:
I follow a similar pattern to the Tango "backend" to create the server and do some testing, so any feedback from #66 should feed into this