Added Item_Model property and mechanism #2805
Closed
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davight
reviewed
Jan 12, 2026
Comment on lines
45
to
50
| if (mechanism.hasValue()) { | ||
| meta.setItemModel(NamespacedKey.fromString(value.asString())); | ||
| } | ||
| else { | ||
| meta.setItemModel(null); | ||
| } |
MC-Samuel
reviewed
Jan 12, 2026
Comment on lines
3
to
17
| import com.denizenscript.denizen.nms.NMSHandler; | ||
| import com.denizenscript.denizen.objects.ItemTag; | ||
| import com.denizenscript.denizencore.objects.Mechanism; | ||
| import com.denizenscript.denizencore.objects.ObjectTag; | ||
| import com.denizenscript.denizencore.objects.core.ElementTag; | ||
| import com.denizenscript.denizencore.objects.core.ListTag; | ||
| import com.denizenscript.denizencore.objects.properties.Property; | ||
| import com.denizenscript.denizencore.objects.properties.PropertyParser; | ||
| import com.denizenscript.denizencore.tags.Attribute; | ||
| import com.denizenscript.denizencore.tags.core.EscapeTagUtil; | ||
| import com.denizenscript.denizencore.utilities.CoreUtilities; | ||
| import org.bukkit.NamespacedKey; | ||
| import org.bukkit.inventory.meta.ItemMeta; | ||
|
|
||
| import java.util.List; |
Contributor
There was a problem hiding this comment.
Should clean up imports, a lot of these aren't used.
Member
|
Thank you for the PR, but properties for item components will have a dedicated system added for them (see #2760), so these will need to wait until that system is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I decided to switch my server from using custom_model_data towards using Item-Models where possible and thought it would be a convenient feature to have a mechanism for this built into Denizen.