-
Notifications
You must be signed in to change notification settings - Fork 324
Prepare for JEP 500 #9557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Prepare for JEP 500 #9557
Conversation
This comment has been minimized.
This comment has been minimized.
d2219bc to
5c24855
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~c997577e23, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085236
Total [baseline] (8.786 s) : 0, 8785906
Agent [candidate] (1.086 s) : 0, 1086004
Total [candidate] (8.778 s) : 0, 8778139
section iast
Agent [baseline] (1.222 s) : 0, 1221572
Total [baseline] (9.344 s) : 0, 9343668
Agent [candidate] (1.227 s) : 0, 1226740
Total [candidate] (9.371 s) : 0, 9371392
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~c997577e23, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (651.886 ms) : 0, 651886
BytebuddyAgent [candidate] (652.278 ms) : 0, 652278
GlobalTracer [baseline] (283.714 ms) : 0, 283714
GlobalTracer [candidate] (283.712 ms) : 0, 283712
AppSec [baseline] (32.7 ms) : 0, 32700
AppSec [candidate] (32.572 ms) : 0, 32572
Debugger [baseline] (67.091 ms) : 0, 67091
Debugger [candidate] (67.395 ms) : 0, 67395
Remote Config [baseline] (630.936 µs) : 0, 631
Remote Config [candidate] (631.509 µs) : 0, 632
Telemetry [baseline] (8.789 ms) : 0, 8789
Telemetry [candidate] (8.897 ms) : 0, 8897
Flare Poller [baseline] (3.824 ms) : 0, 3824
Flare Poller [candidate] (3.852 ms) : 0, 3852
section iast
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (790.916 ms) : 0, 790916
BytebuddyAgent [candidate] (793.717 ms) : 0, 793717
GlobalTracer [baseline] (256.102 ms) : 0, 256102
GlobalTracer [candidate] (257.288 ms) : 0, 257288
IAST [baseline] (26.871 ms) : 0, 26871
IAST [candidate] (27.03 ms) : 0, 27030
AppSec [baseline] (33.499 ms) : 0, 33499
AppSec [candidate] (32.617 ms) : 0, 32617
Debugger [baseline] (65.247 ms) : 0, 65247
Debugger [candidate] (66.904 ms) : 0, 66904
Remote Config [baseline] (578.513 µs) : 0, 579
Remote Config [candidate] (576.016 µs) : 0, 576
Telemetry [baseline] (8.395 ms) : 0, 8395
Telemetry [candidate] (8.524 ms) : 0, 8524
Flare Poller [baseline] (3.548 ms) : 0, 3548
Flare Poller [candidate] (3.672 ms) : 0, 3672
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~c997577e23, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092668
Total [baseline] (10.88 s) : 0, 10880267
Agent [candidate] (1.096 s) : 0, 1096040
Total [candidate] (10.888 s) : 0, 10887512
section appsec
Agent [baseline] (1.272 s) : 0, 1271865
Total [baseline] (10.996 s) : 0, 10996339
Agent [candidate] (1.268 s) : 0, 1267710
Total [candidate] (11.1 s) : 0, 11100266
section iast
Agent [baseline] (1.233 s) : 0, 1233204
Total [baseline] (11.239 s) : 0, 11239263
Agent [candidate] (1.228 s) : 0, 1228268
Total [candidate] (11.164 s) : 0, 11163618
section profiling
Agent [baseline] (1.204 s) : 0, 1203931
Total [baseline] (10.897 s) : 0, 10897162
Agent [candidate] (1.208 s) : 0, 1208268
Total [candidate] (10.901 s) : 0, 10900847
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~c997577e23, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (655.73 ms) : 0, 655730
BytebuddyAgent [candidate] (658.508 ms) : 0, 658508
GlobalTracer [baseline] (285.072 ms) : 0, 285072
GlobalTracer [candidate] (285.513 ms) : 0, 285513
AppSec [baseline] (32.886 ms) : 0, 32886
AppSec [candidate] (32.836 ms) : 0, 32836
Debugger [baseline] (67.053 ms) : 0, 67053
Debugger [candidate] (68.757 ms) : 0, 68757
Remote Config [baseline] (626.165 µs) : 0, 626
Remote Config [candidate] (635.232 µs) : 0, 635
Telemetry [baseline] (9.012 ms) : 0, 9012
Telemetry [candidate] (9.006 ms) : 0, 9006
Flare Poller [baseline] (5.453 ms) : 0, 5453
Flare Poller [candidate] (3.871 ms) : 0, 3871
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (695.036 ms) : 0, 695036
BytebuddyAgent [candidate] (691.856 ms) : 0, 691856
GlobalTracer [baseline] (260.47 ms) : 0, 260470
GlobalTracer [candidate] (260.004 ms) : 0, 260004
AppSec [baseline] (173.845 ms) : 0, 173845
AppSec [candidate] (173.401 ms) : 0, 173401
Debugger [baseline] (67.177 ms) : 0, 67177
Debugger [candidate] (67.284 ms) : 0, 67284
Remote Config [baseline] (791.272 µs) : 0, 791
Remote Config [candidate] (762.813 µs) : 0, 763
Telemetry [baseline] (9.414 ms) : 0, 9414
Telemetry [candidate] (9.41 ms) : 0, 9410
Flare Poller [baseline] (3.745 ms) : 0, 3745
Flare Poller [candidate] (3.791 ms) : 0, 3791
IAST [baseline] (24.727 ms) : 0, 24727
IAST [candidate] (24.577 ms) : 0, 24577
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (798.156 ms) : 0, 798156
BytebuddyAgent [candidate] (794.906 ms) : 0, 794906
GlobalTracer [baseline] (258.097 ms) : 0, 258097
GlobalTracer [candidate] (257.348 ms) : 0, 257348
AppSec [baseline] (33.622 ms) : 0, 33622
AppSec [candidate] (33.318 ms) : 0, 33318
Debugger [baseline] (66.881 ms) : 0, 66881
Debugger [candidate] (66.566 ms) : 0, 66566
Remote Config [baseline] (609.123 µs) : 0, 609
Remote Config [candidate] (576.802 µs) : 0, 577
Telemetry [baseline] (8.497 ms) : 0, 8497
Telemetry [candidate] (8.434 ms) : 0, 8434
Flare Poller [baseline] (3.575 ms) : 0, 3575
Flare Poller [candidate] (3.566 ms) : 0, 3566
IAST [baseline] (27.192 ms) : 0, 27192
IAST [candidate] (27.031 ms) : 0, 27031
section profiling
ProfilingAgent [baseline] (96.382 ms) : 0, 96382
ProfilingAgent [candidate] (96.871 ms) : 0, 96871
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (701.364 ms) : 0, 701364
BytebuddyAgent [candidate] (704.199 ms) : 0, 704199
GlobalTracer [baseline] (221.691 ms) : 0, 221691
GlobalTracer [candidate] (222.498 ms) : 0, 222498
AppSec [baseline] (32.306 ms) : 0, 32306
AppSec [candidate] (32.492 ms) : 0, 32492
Debugger [baseline] (67.896 ms) : 0, 67896
Debugger [candidate] (68.009 ms) : 0, 68009
Remote Config [baseline] (628.325 µs) : 0, 628
Remote Config [candidate] (637.197 µs) : 0, 637
Telemetry [baseline] (8.875 ms) : 0, 8875
Telemetry [candidate] (8.787 ms) : 0, 8787
Flare Poller [baseline] (3.722 ms) : 0, 3722
Flare Poller [candidate] (3.675 ms) : 0, 3675
Profiling [baseline] (96.948 ms) : 0, 96948
Profiling [candidate] (97.45 ms) : 0, 97450
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c997577e23, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section baseline
no_agent (17.95 ms) : 17769, 18131
. : milestone, 17950,
appsec (18.647 ms) : 18458, 18837
. : milestone, 18647,
code_origins (17.627 ms) : 17452, 17803
. : milestone, 17627,
iast (18.849 ms) : 18660, 19039
. : milestone, 18849,
profiling (19.118 ms) : 18925, 19310
. : milestone, 19118,
tracing (17.804 ms) : 17626, 17982
. : milestone, 17804,
section candidate
no_agent (18.056 ms) : 17874, 18238
. : milestone, 18056,
appsec (18.779 ms) : 18590, 18969
. : milestone, 18779,
code_origins (17.889 ms) : 17709, 18068
. : milestone, 17889,
iast (17.608 ms) : 17431, 17784
. : milestone, 17608,
profiling (18.833 ms) : 18645, 19020
. : milestone, 18833,
tracing (17.432 ms) : 17256, 17607
. : milestone, 17432,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c997577e23, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section baseline
no_agent (1.187 ms) : 1175, 1199
. : milestone, 1187,
iast (3.079 ms) : 3035, 3123
. : milestone, 3079,
iast_FULL (5.907 ms) : 5848, 5967
. : milestone, 5907,
iast_GLOBAL (3.514 ms) : 3465, 3563
. : milestone, 3514,
profiling (1.985 ms) : 1968, 2003
. : milestone, 1985,
tracing (1.79 ms) : 1775, 1804
. : milestone, 1790,
section candidate
no_agent (1.183 ms) : 1171, 1194
. : milestone, 1183,
iast (3.328 ms) : 3280, 3375
. : milestone, 3328,
iast_FULL (5.567 ms) : 5513, 5621
. : milestone, 5567,
iast_GLOBAL (3.58 ms) : 3524, 3636
. : milestone, 3580,
profiling (1.993 ms) : 1976, 2010
. : milestone, 1993,
tracing (1.86 ms) : 1844, 1877
. : milestone, 1860,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c997577e23, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1480
. : milestone, 1469,
appsec (2.523 ms) : 2468, 2578
. : milestone, 2523,
iast (2.224 ms) : 2158, 2290
. : milestone, 2224,
iast_GLOBAL (2.263 ms) : 2197, 2329
. : milestone, 2263,
profiling (2.07 ms) : 2017, 2123
. : milestone, 2070,
tracing (2.05 ms) : 1998, 2102
. : milestone, 2050,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.706 ms) : 3487, 3925
. : milestone, 3706,
iast (2.218 ms) : 2152, 2283
. : milestone, 2218,
iast_GLOBAL (2.258 ms) : 2192, 2323
. : milestone, 2258,
profiling (2.087 ms) : 2032, 2142
. : milestone, 2087,
tracing (2.058 ms) : 2006, 2110
. : milestone, 2058,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c997577e23, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section baseline
no_agent (15.329 s) : 15329000, 15329000
. : milestone, 15329000,
appsec (14.745 s) : 14745000, 14745000
. : milestone, 14745000,
iast (18.198 s) : 18198000, 18198000
. : milestone, 18198000,
iast_GLOBAL (17.761 s) : 17761000, 17761000
. : milestone, 17761000,
profiling (14.723 s) : 14723000, 14723000
. : milestone, 14723000,
tracing (14.605 s) : 14605000, 14605000
. : milestone, 14605000,
section candidate
no_agent (15.653 s) : 15653000, 15653000
. : milestone, 15653000,
appsec (14.564 s) : 14564000, 14564000
. : milestone, 14564000,
iast (18.328 s) : 18328000, 18328000
. : milestone, 18328000,
iast_GLOBAL (17.75 s) : 17750000, 17750000
. : milestone, 17750000,
profiling (14.843 s) : 14843000, 14843000
. : milestone, 14843000,
tracing (14.665 s) : 14665000, 14665000
. : milestone, 14665000,
|
5c24855 to
d906b86
Compare
d906b86 to
5ad4f5e
Compare
|
Will we be forbidding |
|
We won't. Quick quote from my doc about the topic:
|
|
Going back to draft to carefully evaluate and document each calls. |
|
This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it. |
|
Let see if it makes the Q1 planning |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (333.185 µs) : 263, 403
. : milestone, 333,
basic (275.196 µs) : 268, 283
. : milestone, 275,
loop (8.96 ms) : 8953, 8966
. : milestone, 8960,
section candidate
noprobe (315.114 µs) : 282, 348
. : milestone, 315,
basic (274.061 µs) : 267, 281
. : milestone, 274,
loop (8.951 ms) : 8946, 8957
. : milestone, 8951,
|
What Does This Do
This PR prepares for the "Prepare to Make Final Mean Final" changes where mutating final field will be forbidden.
Motivation
Adding forbidden API should avoid using this API in the future, decreasing the migration work.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-594