-
Notifications
You must be signed in to change notification settings - Fork 324
Tweak delta to make test less flaky on CI. #10429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexeyKuznetsov-DD
wants to merge
1
commit into
master
Choose a base branch
from
alexeyk/tweak-delta-to-make-test-less-flaky
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tweak delta to make test less flaky on CI. #10429
AlexeyKuznetsov-DD
wants to merge
1
commit into
master
from
alexeyk/tweak-delta-to-make-test-less-flaky
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~171265bc0d, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084260
Total [baseline] (8.75 s) : 0, 8750031
Agent [candidate] (1.084 s) : 0, 1083942
Total [candidate] (8.779 s) : 0, 8779048
section iast
Agent [baseline] (1.224 s) : 0, 1224356
Total [baseline] (9.327 s) : 0, 9326899
Agent [candidate] (1.223 s) : 0, 1222947
Total [candidate] (9.302 s) : 0, 9302428
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~171265bc0d, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (651.8 ms) : 0, 651800
BytebuddyAgent [candidate] (651.151 ms) : 0, 651151
GlobalTracer [baseline] (282.805 ms) : 0, 282805
GlobalTracer [candidate] (283.517 ms) : 0, 283517
AppSec [baseline] (32.484 ms) : 0, 32484
AppSec [candidate] (32.418 ms) : 0, 32418
Debugger [baseline] (65.64 ms) : 0, 65640
Debugger [candidate] (67.035 ms) : 0, 67035
Remote Config [baseline] (624.673 µs) : 0, 625
Remote Config [candidate] (612.624 µs) : 0, 613
Telemetry [baseline] (8.851 ms) : 0, 8851
Telemetry [candidate] (8.807 ms) : 0, 8807
Flare Poller [baseline] (5.335 ms) : 0, 5335
Flare Poller [candidate] (3.848 ms) : 0, 3848
section iast
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (792.539 ms) : 0, 792539
BytebuddyAgent [candidate] (791.233 ms) : 0, 791233
GlobalTracer [baseline] (256.765 ms) : 0, 256765
GlobalTracer [candidate] (256.656 ms) : 0, 256656
AppSec [baseline] (33.506 ms) : 0, 33506
AppSec [candidate] (35.158 ms) : 0, 35158
Debugger [baseline] (65.637 ms) : 0, 65637
Debugger [candidate] (63.859 ms) : 0, 63859
Remote Config [baseline] (580.346 µs) : 0, 580
Remote Config [candidate] (559.08 µs) : 0, 559
Telemetry [baseline] (8.379 ms) : 0, 8379
Telemetry [candidate] (8.398 ms) : 0, 8398
Flare Poller [baseline] (3.572 ms) : 0, 3572
Flare Poller [candidate] (3.605 ms) : 0, 3605
IAST [baseline] (26.985 ms) : 0, 26985
IAST [candidate] (26.951 ms) : 0, 26951
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~171265bc0d, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093774
Total [baseline] (10.83 s) : 0, 10829926
Agent [candidate] (1.088 s) : 0, 1087823
Total [candidate] (10.827 s) : 0, 10827241
section appsec
Agent [baseline] (1.264 s) : 0, 1263615
Total [baseline] (10.999 s) : 0, 10999015
Agent [candidate] (1.266 s) : 0, 1266349
Total [candidate] (11.06 s) : 0, 11059870
section iast
Agent [baseline] (1.235 s) : 0, 1234780
Total [baseline] (11.243 s) : 0, 11242798
Agent [candidate] (1.227 s) : 0, 1227421
Total [candidate] (11.125 s) : 0, 11124720
section profiling
Agent [baseline] (1.204 s) : 0, 1203592
Total [baseline] (10.892 s) : 0, 10891958
Agent [candidate] (1.205 s) : 0, 1205326
Total [candidate] (10.938 s) : 0, 10937705
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~171265bc0d, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.168 ms) : 0, 1168
BytebuddyAgent [baseline] (657.219 ms) : 0, 657219
BytebuddyAgent [candidate] (652.182 ms) : 0, 652182
GlobalTracer [baseline] (285.282 ms) : 0, 285282
GlobalTracer [candidate] (284.457 ms) : 0, 284457
AppSec [baseline] (32.596 ms) : 0, 32596
AppSec [candidate] (32.571 ms) : 0, 32571
Debugger [baseline] (66.817 ms) : 0, 66817
Debugger [candidate] (67.908 ms) : 0, 67908
Remote Config [baseline] (642.089 µs) : 0, 642
Remote Config [candidate] (634.109 µs) : 0, 634
Telemetry [baseline] (8.941 ms) : 0, 8941
Telemetry [candidate] (8.902 ms) : 0, 8902
Flare Poller [baseline] (5.475 ms) : 0, 5475
Flare Poller [candidate] (4.603 ms) : 0, 4603
section appsec
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (690.059 ms) : 0, 690059
BytebuddyAgent [candidate] (691.443 ms) : 0, 691443
GlobalTracer [baseline] (258.689 ms) : 0, 258689
GlobalTracer [candidate] (259.47 ms) : 0, 259470
AppSec [baseline] (172.034 ms) : 0, 172034
AppSec [candidate] (170.723 ms) : 0, 170723
Debugger [baseline] (67.95 ms) : 0, 67950
Debugger [candidate] (69.663 ms) : 0, 69663
Remote Config [baseline] (786.857 µs) : 0, 787
Remote Config [candidate] (778.262 µs) : 0, 778
Telemetry [baseline] (9.361 ms) : 0, 9361
Telemetry [candidate] (9.256 ms) : 0, 9256
Flare Poller [baseline] (3.716 ms) : 0, 3716
Flare Poller [candidate] (3.809 ms) : 0, 3809
IAST [baseline] (24.473 ms) : 0, 24473
IAST [candidate] (24.671 ms) : 0, 24671
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (798.747 ms) : 0, 798747
BytebuddyAgent [candidate] (794.971 ms) : 0, 794971
GlobalTracer [baseline] (258.254 ms) : 0, 258254
GlobalTracer [candidate] (256.434 ms) : 0, 256434
AppSec [baseline] (33.717 ms) : 0, 33717
AppSec [candidate] (34.226 ms) : 0, 34226
Debugger [baseline] (67.316 ms) : 0, 67316
Debugger [candidate] (65.651 ms) : 0, 65651
Remote Config [baseline] (572.269 µs) : 0, 572
Remote Config [candidate] (593.162 µs) : 0, 593
Telemetry [baseline] (8.505 ms) : 0, 8505
Telemetry [candidate] (8.412 ms) : 0, 8412
Flare Poller [baseline] (3.639 ms) : 0, 3639
Flare Poller [candidate] (3.545 ms) : 0, 3545
IAST [baseline] (27.318 ms) : 0, 27318
IAST [candidate] (26.986 ms) : 0, 26986
section profiling
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (700.809 ms) : 0, 700809
BytebuddyAgent [candidate] (701.388 ms) : 0, 701388
GlobalTracer [baseline] (221.675 ms) : 0, 221675
GlobalTracer [candidate] (221.43 ms) : 0, 221430
AppSec [baseline] (32.167 ms) : 0, 32167
AppSec [candidate] (32.334 ms) : 0, 32334
Debugger [baseline] (67.74 ms) : 0, 67740
Debugger [candidate] (67.765 ms) : 0, 67765
Remote Config [baseline] (664.788 µs) : 0, 665
Remote Config [candidate] (664.044 µs) : 0, 664
Telemetry [baseline] (9.032 ms) : 0, 9032
Telemetry [candidate] (9.031 ms) : 0, 9031
Flare Poller [baseline] (3.752 ms) : 0, 3752
Flare Poller [candidate] (3.825 ms) : 0, 3825
ProfilingAgent [baseline] (96.833 ms) : 0, 96833
ProfilingAgent [candidate] (97.808 ms) : 0, 97808
Profiling [baseline] (97.411 ms) : 0, 97411
Profiling [candidate] (98.396 ms) : 0, 98396
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~171265bc0d, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section baseline
no_agent (1.198 ms) : 1186, 1210
. : milestone, 1198,
iast (3.102 ms) : 3061, 3142
. : milestone, 3102,
iast_FULL (5.684 ms) : 5629, 5739
. : milestone, 5684,
iast_GLOBAL (3.495 ms) : 3448, 3542
. : milestone, 3495,
profiling (1.992 ms) : 1975, 2009
. : milestone, 1992,
tracing (1.767 ms) : 1752, 1781
. : milestone, 1767,
section candidate
no_agent (1.186 ms) : 1175, 1197
. : milestone, 1186,
iast (3.272 ms) : 3228, 3315
. : milestone, 3272,
iast_FULL (5.762 ms) : 5704, 5819
. : milestone, 5762,
iast_GLOBAL (3.427 ms) : 3380, 3475
. : milestone, 3427,
profiling (2.041 ms) : 2023, 2059
. : milestone, 2041,
tracing (1.886 ms) : 1868, 1904
. : milestone, 1886,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~171265bc0d, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section baseline
no_agent (17.963 ms) : 17781, 18144
. : milestone, 17963,
appsec (18.987 ms) : 18793, 19180
. : milestone, 18987,
code_origins (17.621 ms) : 17447, 17794
. : milestone, 17621,
iast (17.793 ms) : 17616, 17970
. : milestone, 17793,
profiling (19.955 ms) : 19755, 20156
. : milestone, 19955,
tracing (17.795 ms) : 17617, 17973
. : milestone, 17795,
section candidate
no_agent (18.228 ms) : 18042, 18415
. : milestone, 18228,
appsec (18.731 ms) : 18541, 18922
. : milestone, 18731,
code_origins (17.754 ms) : 17578, 17931
. : milestone, 17754,
iast (17.514 ms) : 17343, 17685
. : milestone, 17514,
profiling (19.159 ms) : 18962, 19356
. : milestone, 19159,
tracing (17.885 ms) : 17708, 18061
. : milestone, 17885,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~171265bc0d, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section baseline
no_agent (15.633 s) : 15633000, 15633000
. : milestone, 15633000,
appsec (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
iast (17.88 s) : 17880000, 17880000
. : milestone, 17880000,
iast_GLOBAL (17.744 s) : 17744000, 17744000
. : milestone, 17744000,
profiling (15.142 s) : 15142000, 15142000
. : milestone, 15142000,
tracing (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
section candidate
no_agent (15.326 s) : 15326000, 15326000
. : milestone, 15326000,
appsec (14.906 s) : 14906000, 14906000
. : milestone, 14906000,
iast (17.973 s) : 17973000, 17973000
. : milestone, 17973000,
iast_GLOBAL (17.925 s) : 17925000, 17925000
. : milestone, 17925000,
profiling (14.915 s) : 14915000, 14915000
. : milestone, 14915000,
tracing (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~171265bc0d, baseline=1.59.0-SNAPSHOT~3d62379c90
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.731 ms) : 3511, 3951
. : milestone, 3731,
iast (2.2 ms) : 2135, 2264
. : milestone, 2200,
iast_GLOBAL (2.245 ms) : 2180, 2311
. : milestone, 2245,
profiling (2.067 ms) : 2015, 2120
. : milestone, 2067,
tracing (2.052 ms) : 2001, 2104
. : milestone, 2052,
section candidate
no_agent (1.479 ms) : 1467, 1491
. : milestone, 1479,
appsec (3.65 ms) : 3436, 3864
. : milestone, 3650,
iast (2.21 ms) : 2145, 2275
. : milestone, 2210,
iast_GLOBAL (2.257 ms) : 2191, 2323
. : milestone, 2257,
profiling (2.088 ms) : 2034, 2142
. : milestone, 2088,
tracing (2.055 ms) : 2003, 2106
. : milestone, 2055,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: api
Tracer public API
comp: core
Tracer core
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Tweak delta to relax test conditions on CI.
Motivation
Reduce test flakiness.
Additional Notes
In CI environments, thread scheduling, GC pauses, and CPU contention can easily push timings beyond specified limits.
That is usually results in flaky test with error like: