Skip to content

Conversation

@toniprieto
Copy link
Contributor

@toniprieto toniprieto commented Jan 22, 2026

References

Description

This PR introduces local translations for Creative Commons license answer labels that are returned untranslated by the CC API.

Note: This is a temporary workaround while the legacy CC API integration is still in use. See: DSpace/DSpace#9397

Instructions for Reviewers

List of changes in this PR:

  • Updated the CC License submission component to translate Creative Commons answer labels locally instead of displaying raw values from the CC API.
  • Added new i18n translation keys for CC license answers (Yes, No, ShareAlike) in English, Spanish, and Catalan

To test it:

  • Enable the cclicense step in item-submission.xml.
  • Comment out or leave empty the cc.license.locale property in dspace.cfg.
  • Configure supported locales in dspace.cfg, for example:
webui.supported.locales` = en, ca, es
  • Start a new item submission and verify that CC license answers are properly translated according to the selected UI language.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge integration: Creative Commons Related to CC license labels Jan 22, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jan 22, 2026
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Jan 22, 2026
@rwangsp
Copy link

rwangsp commented Jan 23, 2026

Hi @tdonohue please could you assign me as reviewer for the main branch fix and the ports? Thank you! 🎉

And thank you @toniprieto for putting together the PRs! 🎉

@tdonohue
Copy link
Member

@rwangsp : Because of limitations in GitHub, I cannot assign anyone to PRs who is not in the "DSpace" project in GitHub. However, you still are able to submit reviews for any PR you wish...and once you submit a review, your name/GitHub ID will appear in the "Reviewers" list for that PR. So, please do review these PRs whenever you are able to do so. We encourage anyone to review or test any PR they wish, as it helps us to understand whether the PR is working properly, etc.

@rwangsp
Copy link

rwangsp commented Jan 23, 2026

Hi @tdonohue thank you for letting me know! Okay I will update once the reviews are completed. Thank you everyone! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug integration: Creative Commons Related to CC license port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Labels for Radio buttons in Creative Commons License Selection Appear in English when French language selected

3 participants