Skip to content

Conversation

@Mehrn0ush
Copy link

As discussed in ticket #752, this PR fixes a data-quality issue in the Cryptography Registry.

Fixes #752

Details

  • Removes a duplicate BLAKE2b-(160|256|384|512)-HMAC variant entry (primitive: mac)

Scope

  • Cryptography Registry data only (schema/cryptography-defs.json)
  • No schema or specification behavior changes

@Mehrn0ush Mehrn0ush requested a review from a team as a code owner December 30, 2025 17:31
@stevespringett
Copy link
Member

cc: @bhess

@stevespringett stevespringett added the cap: cryptography Capability: Cryptography (CBOM) label Jan 2, 2026
Copy link
Contributor

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for highlighting this issue, @Mehrn0ush. Please see my inline comment, it seems to be a typo that caused the duplicate.

"primitive": "hash"
},
{
"pattern": "BLAKE2b-(160|256|384|512)-HMAC",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention was to describe BLAKE2s with HMAC (instead of BLAKE2b), so this appears to be a typo that caused the duplicate. Could you please update the pattern to BLAKE2s-(160|256|384|512)-HMAC rather than removing the entry?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @bhess — agreed this was a typo.

I updated the entry to preserve both HMAC variants by correcting the duplicate to:

  • BLAKE2s-(160|256)-HMAC

Note: BLAKE2s only defines 160/256-bit digests (whereas BLAKE2b supports up to 512), so I kept the size set aligned with the existing BLAKE2s-(160|256) variant.

PR updated (amended) accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
@Mehrn0ush Mehrn0ush force-pushed the fix/crypto-registry-blake2-dup branch from 4e67374 to f2a2652 Compare January 5, 2026 16:29
Copy link
Contributor

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cap: cryptography Capability: Cryptography (CBOM)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Defect]: Duplicate BLAKE2b-HMAC variant in Cryptography Registry

3 participants