Skip to content

Conversation

@alhendrickson
Copy link
Collaborator

@alhendrickson alhendrickson commented Jan 21, 2026

  • Build a docker image every PR for use with previews
  • Standardise to use the official github docker actions instead of custom CLI
  • Add docker caching to speed up actions
  • Consolidate the workflows into one file
  • Make the flows consistent with the medcat-service workflow

Main reason I wanted to do this is to get the PR builds so I can optionally run trainer with a PR

@alhendrickson alhendrickson changed the title build(medcat-trainer): Build docker image every PR. Use standardised github actions for docker build(medcat-trainer): Consolidate github flows into one. Use standardised github actions for docker Jan 21, 2026
@alhendrickson alhendrickson marked this pull request as ready for review January 21, 2026 12:32
Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - totally here for reducing the number of gha workflows!

cd client
python -m build

- name: Bump version for TestPyPI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - this was on the todo list!

@alhendrickson alhendrickson merged commit 4a407c0 into main Jan 21, 2026
10 checks passed
@alhendrickson alhendrickson deleted the build/medcat-trainer/improve-trainer-ci-build branch January 21, 2026 13:41
tomolopolis pushed a commit that referenced this pull request Jan 22, 2026
…dised github actions for docker (#302)

* build(medcat-trainer): Use Docker actions for github CI builds

* build(medcat-trainer): Create a docker image for every PR

* build(medcat-trainer): Consolidate workflows into one file. Updating docker action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants