feat: add parchment layout #2459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielku15
force-pushed
the
feature/parchment
branch
from
fa8a50e to
217cd50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1987
Proposed changes
Beside some cleanup work this PR adds a new parchment layout which always uses the systems layout from the data model.
The width of the container is still followed and users can fix them manually (e.g. to an A4) by own means.
For the print layout (#1988) in future we will add actual page size information which could become an opt-in (with alternative scaling to fit the viewport?) -> Something for the future.
For the horizontal layout we now always respect and widths configured. As this is a special alphaTex feature, we can safely assume that people want it active when specified.
Checklist
Further details