West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 2 | Module-data-groups/Sprint-2

[Baba05206]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Completed required sprint 2 tasks covering debug, implement and interpret

Questions

[WeiTsungCheng]

Overall, it's quite good. There are a few areas that could be further considered.

[WeiTsungCheng]

Correct! One could consider whether a default value could be provided if a corresponding key does not exist.

[WeiTsungCheng]

nice !

[WeiTsungCheng]

This condition (invalid parameters (like array) → return false or throw an error) is not satisfied
e.g contains([1, 2, 3], "2")

[WeiTsungCheng]

ok. it works

[WeiTsungCheng]

1. The array type in the problem is not restricted; it could be numbers or text. You should first check if it's text.

2. The divisor should only count the number of columns occupied by significant numbers. However, let count = list.length will average the total values ​​in the array.

[WeiTsungCheng]

Your sum only adds valid numbers,
but count = list.length still includes invalid values.

[Baba05206]

@WeiTsungCheng , may I ask for your feedback on the updated response please? Thank you.

[WeiTsungCheng]

Hi @Baba05206 sure, I will update it today

[WeiTsungCheng]

ok nice job

[Baba05206]

many thanks @WeiTsungCheng . is this completed now?

[Baba05206]

does it need to be marked as completed?

[WeiTsungCheng]

please check mean.js file's comment

[Baba05206]

@WeiTsungCheng , please pardon me but I am unable to find mean.js or its comments in Sprint-2. What am i missing? Can we do a call in the morning so you could kindly show me what I am missing please?

[Baba05206]

i looked in the upstream repo as well and could not find mean.js task.

[Baba05206]

Hi William, I now know what happened and this was all my fault. There was a prep/mean.js exercise that should never have been submitted. I submitted this in error and deleted the folder when the error was pointed out to me by CJ. I should have closed the comment before deleting the prep folder and its contents. I do apologize for making you review a part of the task that was not in scope for the PR. I am sorry for causing the confusion. Prep and its content was not required to be submitted.

[WeiTsungCheng]

Don't worry too much. I just hoped I could be of some help with your studies.
Good luck!

[Baba05206]

This PR is now completed.

[cjyuan]

@WeiTsungCheng

I mistakenly thought you didn't have the permission to add labels, so I added the "Complete" label just now.

As mentors, once we feel a PR review is complete, we go ahead and add the “Complete” label ourselves. If you’ve seen any instructions that say (or suggest) something different, please let me know and I would be happy to update the documentation so everything stays clear and consistent.

Thanks.

[WeiTsungCheng]

@WeiTsungCheng

I mistakenly thought you didn't have the permission to add labels, so I added the "Complete" label just now.

As mentors, once we feel a PR review is complete, we go ahead and add the “Complete” label ourselves. If you’ve seen any instructions that say (or suggest) something different, please let me know and I would be happy to update the documentation so everything stays clear and consistent.

Thanks.

Sorry, I may have misunderstood this earlier. As a code reviewer (not a mentor), I previously thought I only needed to change the status to reviewed. I’ll make sure to add the complete label going forward. Thanks for your reply.