Skip to content

Glasgow | 25-ITP-Sept | Shreef Ibrahim | Sprint 2 | Book Library #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shreefAhmedM wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Glasgow | 25-ITP-Sept | Shreef Ibrahim | Sprint 2 | Book Library #366

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a0a268
book laibrary has been completed
shreefAhmedM Dec 17, 2025
05f6ca0
Add error message and improving the code
shreefAhmedM Dec 19, 2025
5c86e22
Refactor page number validation
shreefAhmedM Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 48 additions & 90 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,54 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<head>
<meta charset="utf-8" />
<title>Library</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" />
<link rel="stylesheet" href="style.css" />
</head>
<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
<div id="errorMessage"></div>
<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input type="text" class="form-control" id="titleInput" name="title" required />
<label for="author">Author:</label>
<input type="text" class="form-control" id="authorInput" name="author" required />
<label for="pages">Pages:</label>
<input type="number" class="form-control" id="pagesInput" name="pages" required />

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<label class="form-check-label">
<input type="checkbox" class="form-check-input" id="readInput" />
Read
</label>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
<button id="submitBtn" class="btn btn-primary">Submit</button>
</div>
</div>
<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody></tbody>
</table>
<script src="https://code.jquery.com/jquery-3.4.1.slim.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<script src="script.js" type="module"></script>
</body>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>

<script src="script.js"></script>
</body>
</html>
</html>
173 changes: 89 additions & 84 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,108 @@
let myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
const titleInput = document.getElementById("titleInput");
const authorInput = document.getElementById("authorInput");
const pagesInput = document.getElementById("pagesInput");
const readInput = document.getElementById("readInput");
const errorBox = document.getElementById("errorMessage");
const tableBody = document.querySelector("#display tbody");

window.addEventListener("load", () => {
populateInitialBooks();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
function Book(title, author, pages, read) {
this.title = title;
this.author = author;
this.pages = pages; // number
this.read = read; // boolean
}

function populateInitialBooks() {
if (myLibrary.length > 0) return;

myLibrary.push(
new Book("Robinson Crusoe", "Daniel Defoe", 252, true),
new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true)
);
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
function addBook() {
const title = titleInput.value.trim();
const author = authorInput.value.trim();
const pages = pagesInput.value.trim();
const read = readInput.checked;

if (!title || !author || !pages) {
showError("Please fill all fields!");
return;
}

if (isNaN(Number(pages)) || Number(pages) <= 0) {
showError("Pages must be a positive number.");
return;
}
Copy link
Contributor

@cjyuan cjyuan Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why not stored the converted number to a variable first to avoid unnecessary conversions?

  • Some invalid "number of pages" can still pass this check. Can you strengthen the check?

Copy link
Author

@shreefAhmedM shreefAhmedM Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you i have updated


if (myLibrary.some(b => b.title === title && b.author === author)) {
showError("This book already exists!");
return;
}

const book = new Book(title, author, Number(pages), read);
myLibrary.push(book);
clearForm();
render();
}

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
document.getElementById("submitBtn").addEventListener("click", addBook);

function clearForm() {
titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
readInput.checked = false;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
tableBody.innerHTML = "";

myLibrary.forEach((book, index) => {
const row = tableBody.insertRow();

const titleCell = row.insertCell();
const authorCell = row.insertCell();
const pagesCell = row.insertCell();
const readCell = row.insertCell();
const deleteCell = row.insertCell();

titleCell.textContent = book.title;
authorCell.textContent = book.author;
pagesCell.textContent = book.pages;

const toggleBtn = document.createElement("button");
toggleBtn.className = book.read ? "btn btn-success" : "btn btn-primary";
toggleBtn.textContent = book.read ? "Yes" : "No";
toggleBtn.addEventListener("click", () => {
book.read = !book.read;
render();
});
readCell.appendChild(toggleBtn);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
const delBtn = document.createElement("button");
delBtn.className = "btn btn-warning";
delBtn.textContent = "Delete";
delBtn.addEventListener("click", () => {
myLibrary.splice(index, 1);
render();
showError(`Deleted: ${book.title}`);
});
}
deleteCell.appendChild(delBtn);
});
}

function showError(message) {
errorBox.textContent = message;
errorBox.classList.add("show");
setTimeout(() => errorBox.classList.remove("show"), 3000);
}
25 changes: 23 additions & 2 deletions debugging/book-library/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
.form-group {
width: 400px;
height: 300px;
align-self: left;
padding-left: 20px;
}

Expand All @@ -11,9 +10,31 @@

.form-check-label {
padding-left: 20px;
margin: 5px 0px 5px 0px;
margin: 5px 0;
}

button.btn-info {
margin: 20px;
}

#errorMessage {
margin-right: 0;
color: white;
background-color: hsla(0, 88%, 42%, 0.7);
padding: 20px;
border-radius: 5px;
width: 30%;
text-align: center;
font-weight: bold;
display: none;
position: absolute;
z-index: 1000;
top: 20px;
right: 20px;
}

#errorMessage.show {
display: block;
opacity: 1;
transform: translateX(0);
}
Loading