Add walltime benchmarking algorithm to exec-harness #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
from
5987856 to
7c43710
Compare
not-matthias
reviewed
Jan 6, 2026
Member
not-matthias
left a comment
not-matthias
left a comment
There was a problem hiding this comment.
A few minor things that can be improved, otherwise looks really good! :)
Comment on lines
33
to
55
| hooks | ||
| .add_benchmark_timestamps(warmup_iteration_start_ts_ns, warmup_iteration_end_ts_ns); |
Member
There was a problem hiding this comment.
We're including the warmup timestamps in the actual benchmark run.
We currently need to ensure that the timestamps actually only track the benchmark execution, since we use it to calculate the approximate time per frame in the flamegraph. Maybe instead save the time, then submit it in the check below that exits after 1 warmup iteration.
Contributor
Author
There was a problem hiding this comment.
actually it's even more scuffed than that fo rnow since the profiling of only one iteration will be shown.
For now, I'll leave it like that, and we'll revisit when we update the profile to manage all the pids
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
3 times, most recently
from
6d9ce97 to
4877ad0
Compare
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
from
4877ad0 to
46b0925
Compare
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
from
46b0925 to
0bde17f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.