Skip to content

Conversation

@GuillaumeLagrange
Copy link
Contributor

instrumentation is still accepted as an input, but it maps to simulation internally, as we plan to phase it out.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 13, 2025

CodSpeed Performance Report

Merging #98 will degrade performances by 13.71%

Comparing cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now (adee8a1) with master (bb84077)

Summary

⚡ 12 improvements
❌ 11 (👁 11) regressions
✅ 144 untouched

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
👁 WallTime test_make_bandpass 5.4 µs 5.6 µs -3.67%
👁 WallTime test_make_lowshelf 7.1 µs 7.3 µs -2.38%
WallTime test_generate_all_combinations[5-4] 9.9 µs 9.7 µs +2.07%
WallTime test_is_complete[board0] 1.8 µs 1.7 µs +4.6%
WallTime test_minimax[scores0] 7.8 µs 7.5 µs +2.83%
👁 WallTime test_solve_power_sum[13-2] 6.9 µs 7.1 µs -3.29%
👁 WallTime test_sum_of_squares[sum_of_squares_sum_comprehension_power] 245.2 µs 284.2 µs -13.71%
👁 WallTime test_sum_of_squares[sum_of_squares_sum_labmda_power] 280.5 µs 304.4 µs -7.84%
WallTime test_sum_of_squares[sum_of_squares_sum_labmda_product] 272.4 µs 246 µs +10.72%
WallTime test_fs_read[1000] 731.7 ns 696.4 ns +5.07%
👁 WallTime test_hostname_resolution[1.1.1.1] 7.2 µs 7.4 µs -2.25%
👁 WallTime test_hostname_resolution[google.com] 381 µs 389.2 µs -2.09%
👁 WallTime test_hostname_resolution[localhost] 117.9 µs 122.2 µs -3.51%
WallTime test_multiprocessing_map[100000] 621.6 ms 600.5 ms +3.51%
WallTime test_multiprocessing_map[10000] 540.1 ms 436.4 ms +23.75%
👁 WallTime test_multiprocessing_map[1000] 309.3 ms 328.1 ms -5.72%
WallTime test_pipe_communication[10000] 14.7 ms 12.2 ms +20.62%
WallTime test_tcp_connection[1.1.1.1-53] 894.5 µs 874.8 µs +2.25%
WallTime test_tcp_connection[8.8.8.8-53] 765.3 µs 652.8 µs +17.23%
WallTime test_tcp_connection[google.com-443] 1.2 ms 1.1 ms +9.71%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@GuillaumeLagrange GuillaumeLagrange changed the title feat: accept rename instrumentation to simulation feat: rename instrumentation to simulation Nov 17, 2025
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch 3 times, most recently from 0e0f5c4 to 2bc4221 Compare November 17, 2025 17:08
@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review November 17, 2025 17:15
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch from 2bc4221 to 069e9b9 Compare November 18, 2025 10:20
`instrumentation` is still accepted as an input, but it maps to
simulation internally, as we plan to phase it out.

Signed-off-by: Guillaume Lagrange <guillaume@glagrange.eu>
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch from 069e9b9 to adee8a1 Compare November 21, 2025 15:04
@GuillaumeLagrange GuillaumeLagrange merged commit adee8a1 into master Nov 21, 2025
36 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now branch November 21, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants