-
Notifications
You must be signed in to change notification settings - Fork 20
feat: rename instrumentation to simulation #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename instrumentation to simulation #150
Conversation
CodSpeed Performance ReportMerging #150 will degrade performances by 29.96%Comparing Summary
Benchmarks breakdown
|
`instrumentation` is still accepted as an input, but it maps to simulation internally, as we plan to phase it out.
98bb927 to
8e5ffb4
Compare
cca86af to
d0c2838
Compare
bec3fc5 to
a49996f
Compare
a49996f to
9181bce
Compare
|
Note that this was a breaking change because it changes the location of the benchmark binary (it's now stored under |
|
@MichaReiser Indeed, although we do consider this implementation details, as we recommend caching Thanks for pointing this out and sorry for the frustration. |
instrumentationis still accepted as an input, but it maps to simulation internally, as we plan to phase it out.