tired

[richiemcilroy]

Greptile Summary

This PR implements several performance and stability improvements across the desktop app:

• Audio playback refactor: Unified audio playback to use prerendered buffers on all platforms instead of Windows-only implementation, with proper sample counter updates for silent frames
• Config update throttling: Enhanced Editor and screenshot editor to use both throttle and trailing debounce, ensuring final updates are never dropped during rapid config changes
• Windows tray icon handling: Added platform-specific guards to prevent tray icon updates on Windows that were causing issues
• Window lifecycle: Improved window cleanup by automatically closing camera window when main window closes
• Preset application: Fixed bug where clips were lost when applying presets by preserving them during normalization
• Type cleanup: Removed unused Windows-specific diagnostic types from auto-generated bindings

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• All changes are well-structured improvements addressing specific bugs and performance issues. The audio refactor properly generalizes Windows-specific code to all platforms. Config throttling improvements prevent dropped updates. Window lifecycle management is enhanced. No logic errors or security concerns identified.
• No files require special attention

Important Files Changed

Filename	Overview
apps/desktop/src-tauri/src/lib.rs	Added camera window cleanup when main window closes - improves window lifecycle management
apps/desktop/src-tauri/src/tray.rs	Added Windows-specific handling to prevent tray icon updates that cause issues on Windows
apps/desktop/src/routes/editor/Editor.tsx	Improved config throttling with trailing debounce to ensure final update is never dropped
apps/desktop/src/routes/editor/PresetsDropdown.tsx	Preserved clips when applying presets to prevent data loss
apps/desktop/src/routes/screenshot-editor/context.tsx	Applied throttle and trailing debounce pattern for screenshot config updates
apps/desktop/src/utils/tauri.ts	Removed unused Windows-specific types from auto-generated bindings
crates/editor/src/audio.rs	Made audio prerendering cross-platform and fixed sample counter updates for silent frames
crates/editor/src/playback.rs	Unified audio playback to use prerendered buffers on all platforms instead of Windows-only

Sequence Diagram

sequenceDiagram
    participant User
    participant MainWindow
    participant CameraWindow
    participant Editor
    participant AudioPlayback
    participant TrayIcon

    User->>Editor: Modify project config
    Editor->>Editor: throttledConfigUpdate(time)
    Editor->>Editor: trailingConfigUpdate(time)
    Note over Editor: Ensures final update<br/>never dropped
    Editor->>AudioPlayback: updateProjectConfigInMemory()
    Editor->>Editor: renderFrame(time)

    User->>MainWindow: Close window
    MainWindow->>MainWindow: Check window type
    alt Is Main Window
        MainWindow->>CameraWindow: close()
        Note over MainWindow,CameraWindow: Auto-cleanup camera<br/>window on main close
    end

    User->>TrayIcon: Recording mode change
    alt Windows Platform
        TrayIcon->>TrayIcon: Skip icon update
        Note over TrayIcon: Prevent Windows<br/>tray issues
    else macOS/Linux
        TrayIcon->>TrayIcon: update_tray_icon_for_mode()
        TrayIcon->>TrayIcon: Set new icon
    end

    User->>AudioPlayback: Start playback
    AudioPlayback->>AudioPlayback: create_stream_prerendered()
    Note over AudioPlayback: Pre-render entire audio<br/>(all platforms now)
    AudioPlayback->>AudioPlayback: Queue audio frames
    loop Playback
        AudioPlayback->>AudioPlayback: Read from buffer
    end

Loading