DO NOT MERGE: Refactor Persistent Workers To Use Kotlin Worker Avoid OOM #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are issues with the current implementation of persistent workers where an OOM will break the RxJava implementation and the message will not relay back to the Bazel server. This will cause builds to run indefinitely. There is a stable version in Rules Kotlin. We will piggy back off of the public implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: DO NOT MERGE THIS. This is just a fix to showcase a potential work around for OOMs for workers on old versions of rules lint
There are issues with the current implementation of persistent workers where an OOM will break the RxJava implementation and the message will not relay back to the Bazel server. This will cause builds to run indefinitely.
There is a stable version in Rules Kotlin. We will piggy back off of the public implementation by patching rules kotlin to expose their implementation and using theirs.
Because of the nature of this fix, if you are on 8.0-, you may have to patch the rules_kotlin in your own WORKSPACE file to make the worker visible as well with