Cpp code organization #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move bgm- and bgmCompare-specific C++ code into src/bgm/ and src/bgmCompare/ - Update build system to support C++ sources in subdirectories - Generate src/sources.mk at configure time to list all .cpp files - Include sources.mk from Makevars.in using portable (CRAN-compliant) rules
- Reorganize remaining C++ files into src/ subdirectories - Include headers relative to src/ and drop per-module -I flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganizes C++ sources into subdirectories under src/, updates header includes to be path-qualified relative to src/, and simplifies the build configuration to use a single include root. The build remains fully portable and CRAN-compliant.