Skip to content

Conversation

@allenkim0129
Copy link
Contributor

@allenkim0129 allenkim0129 commented Dec 22, 2025

Description

Float16 datatype is now supported in Prod accounts.

Changes

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@allenkim0129 allenkim0129 marked this pull request as ready for review December 22, 2025 22:35
@allenkim0129 allenkim0129 requested a review from a team as a code owner December 22, 2025 22:35
Copilot AI review requested due to automatic review settings December 22, 2025 22:35
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please make sure to run the specific tests that are enabeld in this PR, thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables Float16 datatype tests for Azure Cosmos DB vector embeddings, now that Float16 is supported in production accounts. The changes remove a test skip decorator and add corresponding async test coverage.

  • Enables the previously skipped test_create_valid_vector_embedding_policy test in the sync test file
  • Adds missing async test test_create_valid_vector_embedding_policy_async that validates all supported vector data types including float16

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
sdk/cosmos/azure-cosmos/tests/test_vector_policy.py Removes @unittest.skip decorator to enable Float16 testing in sync tests
sdk/cosmos/azure-cosmos/tests/test_vector_policy_async.py Adds async version of the Float16 validation test to match sync test coverage

@allenkim0129
Copy link
Contributor Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@allenkim0129
Copy link
Contributor Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@allenkim0129 allenkim0129 enabled auto-merge (squash) December 23, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants