-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Enable Float16 datatype test #44501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable Float16 datatype test #44501
Conversation
kushagraThapar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please make sure to run the specific tests that are enabeld in this PR, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables Float16 datatype tests for Azure Cosmos DB vector embeddings, now that Float16 is supported in production accounts. The changes remove a test skip decorator and add corresponding async test coverage.
- Enables the previously skipped
test_create_valid_vector_embedding_policytest in the sync test file - Adds missing async test
test_create_valid_vector_embedding_policy_asyncthat validates all supported vector data types including float16
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/tests/test_vector_policy.py | Removes @unittest.skip decorator to enable Float16 testing in sync tests |
| sdk/cosmos/azure-cosmos/tests/test_vector_policy_async.py | Adds async version of the Float16 validation test to match sync test coverage |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Float16datatype is now supported in Prod accounts.Changes
@unittest.skipto enableFloat16tests, as suggested from this previous PR: Adding test for checking float16 datatype for vector embedding policy #43598Float16All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines