-
Notifications
You must be signed in to change notification settings - Fork 30
[WIP] Fully convert project to Kotlin #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As pull requests from a fork doesn't run screenshot compare tests, I'll make a pull request with given changes on upstream |
|
Please see #414 |
# Conflicts: # MPChartLib/src/main/java/com/github/mikephil/charting/charts/CombinedChart.kt
938d078 to
d70e065
Compare
|
I fixed the unit tests and ported in the divide by 0 fix. |
|
Brought it back down to Java 17. There was some clashing with defaults that made me set it to 21, but 17 seems to work locally. |
dd84e09 to
e19f8d6
Compare
|
There is no progress in pull request from fork #413 |
|
@zacharee I don't want to eliminate you motivation to contribute here, but I guess, your probably AI generated, huge change neither run the Espresso tests properly, nor builds to code properly. If you want to continue here, please start again from recent master |
|
This wasn't AI generated, but I lost the time to maintain it. |
|
@zacharee |
|
This https://github.com/AppDevNext/AndroidChart/releases/tag/4.0-beta3 is a Kotlin only version.
|
This PR converts all Java source files to Kotlin. The initial pass was done with Android Studio's automatic converter with manual changes made afterwards to fix errors and improve nullability indicators. Some code paths were also changed to better work with Kotlin.
I did some testing, but I'm sure there are bugs or unintended behavior changes I missed, so I'm marking this as work-in-progress and hoping to have others help test it.
The new codebase is also not API-compatible with the old version. Some of the changes can be tweaked so generated Java setter names match what they used to be, but Kotlin consumers will have to change to property access syntax, and the way Kotlin's generics work required adding more generic types to some classes.