An 118 coordinate upgrade #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- include magic number changes - include retarget diffculty change - include bech32 prefix changes
included preconf included precommitment included asset
|
Are you using any C/C++ formatter? @sucildossj |
jasonribble
reviewed
Sep 12, 2025
| * for the creation of coins out of thin air modification could lead to a fork. | ||
| * */ | ||
| static constexpr CAmount MAX_MONEY = 21000000 * COIN; | ||
| static constexpr CAmount MAX_ASSET_OUT_VALUE = std::numeric_limits<int64_t>::max(); |
There was a problem hiding this comment.
Out of curiosity, what is this about?
Author
There was a problem hiding this comment.
we have asset that will checked against int64_t max number. it remove 21000000 restriction for asset
|
Let me know when it is ready for system level tests; and which scenarios you'd like me to cover |
Author
i used clang-format before |
Author
sure i will let you know this week. Thanks |
jasonribble
reviewed
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.