[PWGCF] Fix FT0 gain correction indexing in longRangeDihadronCor #14489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

MartijnLaarhoven wants to merge 1 commit into AliceO2Group:master from MartijnLaarhoven:fix-ft0-gain-indexing-v3

+27 −0

Contributor

MartijnLaarhoven commented Jan 14, 2026

Use channel ID instead of array index for gain correction
Fixes mismatched amplitude corrections for remapped dead channels


          Fix FT0 gain correction indexing in longRangeDihadronCor

bd2491f

- Use channel ID instead of array index for gain correction
- Fixes mismatched amplitude corrections for remapped dead channels

Copilot AI review requested due to automatic review settings

January 14, 2026 22:13

MartijnLaarhoven requested review from alibuild, ariedel-cern, glromane, lauraser, lgraczykCern, otonvd, prchakra, shouqiye, victor-gonzalez and zchochul as code owners

January 14, 2026 22:13

github-actions bot added the pwgcf label

github-actions bot commented Jan 14, 2026

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 0 disabled

github-actions bot changed the title ~~Fix FT0 gain correction indexing in longRangeDihadronCor~~ [PWGCF] Fix FT0 gain correction indexing in longRangeDihadronCor

Copilot started reviewing on behalf of MartijnLaarhoven

January 14, 2026 22:14

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Pull request overview

This PR attempts to fix FT0 gain correction indexing by using channel IDs instead of array indices, which should correct mismatched amplitude corrections for remapped dead channels. However, the PR contains critical unresolved merge conflicts that prevent it from compiling.

Changes:

Adds duplicate code blocks with merge conflict markers visible in the diff
Introduces temporary variables for mirrored amplitudes in the conflicting sections
Adds channel rejection checks in fillCorrelationsTPCFT0 function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx

Comment on lines +708 to +717

    
              <<<<<<< Updated upstream

                        registry.fill(HIST("FT0Amp"), dead_id, ampl);

                        ampl = ampl / cstFT0RelGain[iCh];

                        registry.fill(HIST("FT0AmpCorrect"), dead_id, ampl);

              =======

                        float mirroredAmpl = ampl;

                        float mirroredAmplCorrected = mirroredAmpl / cstFT0RelGain[iCh];

                        registry.fill(HIST("FT0Amp"), dead_id, mirroredAmpl);

                        registry.fill(HIST("FT0AmpCorrect"), dead_id, mirroredAmplCorrected);

              >>>>>>> Stashed changes

Copilot AI Jan 14, 2026

Unresolved merge conflict in FT0A dead channel remapping code. The file contains Git conflict markers and duplicate code blocks that will prevent compilation. Resolve the merge conflict by choosing the appropriate version or merging the changes properly.

Copilot uses AI. Check for mistakes.

PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx

    
                        int dead_id = id + kFT0CInnerMirror;

              <<<<<<< Updated upstream

                        registry.fill(HIST("FT0Amp"), dead_id, ampl);

                        ampl = ampl / cstFT0RelGain[iCh];

Copilot AI Jan 14, 2026

The gain correction still uses array index iCh instead of channel ID. According to the PR description, this should use the channel ID (id or dead_id) to fix mismatched amplitude corrections for remapped channels. The cstFT0RelGain array has 208 elements indexed by channel ID (0-207), not by array position. This should be cstFT0RelGain[dead_id] to correctly apply the gain correction for the remapped channel.

Copilot uses AI. Check for mistakes.

PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx

    
                      } else if (id >= kFT0CRemapChannelStart && id <= kFT0CRemapChannelEnd) {

                        int dead_id = id + kFT0COuterMirror;

                        registry.fill(HIST("FT0Amp"), dead_id, ampl);

                        ampl = ampl / cstFT0RelGain[iCh];

Copilot AI Jan 14, 2026

The gain correction still uses array index iCh instead of channel ID. According to the PR description, this should use the channel ID (id or dead_id) to fix mismatched amplitude corrections for remapped channels. The cstFT0RelGain array has 208 elements indexed by channel ID (0-207), not by array position. This should be cstFT0RelGain[dead_id] to correctly apply the gain correction for the remapped channel.

Copilot uses AI. Check for mistakes.

PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx

    
                        registry.fill(HIST("FT0AmpCorrect"), dead_id, ampl);

              =======

                        float mirroredAmpl = ampl;

                        float mirroredAmplCorrected = mirroredAmpl / cstFT0RelGain[iCh];

Copilot AI Jan 14, 2026

The gain correction still uses array index iCh instead of channel ID. According to the PR description, this should use the channel ID (id or dead_id) to fix mismatched amplitude corrections for remapped channels. The cstFT0RelGain array has 208 elements indexed by channel ID (0-207), not by array position. This should be cstFT0RelGain[dead_id] to correctly apply the gain correction for the remapped channel.

Copilot uses AI. Check for mistakes.

PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx

    
                      } else if (id >= kFT0CRemapChannelStart && id <= kFT0CRemapChannelEnd) {

                        int dead_id = id + kFT0COuterMirror;

                        float mirroredAmpl = ampl;

                        float mirroredAmplCorrected = mirroredAmpl / cstFT0RelGain[iCh];

Copilot AI Jan 14, 2026

The gain correction still uses array index iCh instead of channel ID. According to the PR description, this should use the channel ID (id or dead_id) to fix mismatched amplitude corrections for remapped channels. The cstFT0RelGain array has 208 elements indexed by channel ID (0-207), not by array position. This should be cstFT0RelGain[dead_id] to correctly apply the gain correction for the remapped channel.

Copilot uses AI. Check for mistakes.

PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx

    
                        int dead_id = id - kFT0AOuterMirror;

              <<<<<<< Updated upstream

                        registry.fill(HIST("FT0Amp"), dead_id, ampl);

                        ampl = ampl / cstFT0RelGain[iCh];

Copilot AI Jan 14, 2026

The gain correction still uses array index iCh instead of channel ID. According to the PR description, this should use the channel ID (id or dead_id) to fix mismatched amplitude corrections for remapped channels. The cstFT0RelGain array has 208 elements indexed by channel ID (0-207), not by array position. This should be cstFT0RelGain[dead_id] to correctly apply the gain correction for the remapped channel.

Copilot uses AI. Check for mistakes.

PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx

    
                        registry.fill(HIST("FT0AmpCorrect"), dead_id, ampl);

              =======

                        float mirroredAmpl = ampl;

                        float mirroredAmplCorrected = mirroredAmpl / cstFT0RelGain[iCh];

Copilot AI Jan 14, 2026

The gain correction still uses array index iCh instead of channel ID. According to the PR description, this should use the channel ID (id or dead_id) to fix mismatched amplitude corrections for remapped channels. The cstFT0RelGain array has 208 elements indexed by channel ID (0-207), not by array position. This should be cstFT0RelGain[dead_id] to correctly apply the gain correction for the remapped channel.

Copilot uses AI. Check for mistakes.

Collaborator

alibuild commented Jan 14, 2026

Error while checking build/O2Physics/o2 for bd2491f at 2026-01-14 23:26:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14489-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:674:1: error: version control conflict marker in file
/sw/SOURCES/O2Physics/14489-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:675:25: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/14489-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:683:1: error: version control conflict marker in file
/sw/SOURCES/O2Physics/14489-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:685:41: error: 'mirroredAmpl' was not declared in this scope
/sw/SOURCES/O2Physics/14489-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:694:1: error: version control conflict marker in file
/sw/SOURCES/O2Physics/14489-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:708:1: error: version control conflict marker in file
/sw/SOURCES/O2Physics/14489-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:709:25: error: expected primary-expression before ')' token
/sw/SOURCES/O2Physics/14489-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:712:1: error: version control conflict marker in file
/sw/SOURCES/O2Physics/14489-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:714:41: error: 'mirroredAmpl' was not declared in this scope
/sw/SOURCES/O2Physics/14489-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/longRangeDihadronCor.cxx:717:1: error: version control conflict marker in file
ninja: build stopped: subcommand failed.

Full log here.

MartijnLaarhoven closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

alibuild Awaiting requested review from alibuild alibuild is a code owner

victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

zchochul Awaiting requested review from zchochul zchochul is a code owner

lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

prchakra Awaiting requested review from prchakra prchakra is a code owner

lauraser Awaiting requested review from lauraser lauraser is a code owner

ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

otonvd Awaiting requested review from otonvd otonvd is a code owner

shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

glromane Awaiting requested review from glromane glromane is a code owner

Labels