[PWGHF] Add preselection and centrality to st tree creator #14252

FDUEnrich · 2025-12-17T08:39:26Z

No description provided.

Fix a name bug.

[PWGHF] Please consider the following formatting changes to AliceO2Group#13353

Added new mass columns for Omega and Xi particles and updated event selection criteria.

…ty-to-STTree-creatore

Please consider the following formatting changes to AliceO2Group#14252

PWGHF/TableProducer/treeCreatorOmegacSt.cxx

…ty-to-STTree-creatore

PWGHF/TableProducer/treeCreatorOmegacSt.cxx

alibuild · 2025-12-30T14:40:55Z

Error while checking build/O2Physics/o2 for 9d4f31c at 2025-12-30 15:40:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

PWGHF/TableProducer/treeCreatorOmegacSt.cxx

vkucera · 2026-01-08T00:33:46Z

PWGHF/TableProducer/treeCreatorOmegacSt.cxx

+      {"hMassXiPi", "inv. mass #Xi + #pi;inv. mass (GeV/#it{c}^{2})", {HistType::kTH1D, {{400, 1.5, 3.}}}},
+      {"hMassXiPiVsPt", "inv. mass #Xi + #pi;inv. mass (GeV/#it{c}^{2});p_{T} (GeV/#it{c})", {HistType::kTH2D, {{400, 1.5, 3.}, {10, 0., 10.}}}},


hMassXiPi is redundant

vkucera · 2026-01-08T00:35:59Z

PWGHF/TableProducer/treeCreatorOmegacSt.cxx

+                      default:
+                        passSelectedChannel = true; // unexpected code -> do not reject
+                        break;


Why do you silently accept unexpected cases?

What is the point of doing this?

I want to either distinguish different decay channel reconstructions or simultaneously reconstruct two or more decay channels. (The logical error has been fixed.)

According to your documentation, the case with all channels is matched to the value AnyChannel, so how can the code do anything useful if it receives an unexpected value?

If I want AnyChannels or other channel, and neither is satisfied, it will enter the default option and continue skipping the loop.

…ty-to-STTree-creatore

Updated variable names for clarity and consistency in the treeCreatorOmegacSt.cxx file. Removed unused histogram for mass Xi + pi.

vkucera · 2026-01-12T12:40:19Z

PWGHF/TableProducer/treeCreatorOmegacSt.cxx

+                    const auto ptCascade = std::hypot(momenta[0][0], momenta[0][1]);
+                    const auto ptPionOrKaon = std::hypot(momenta[1][0], momenta[1][1]);


You could just use RecoDecay::pt(momenta[0]).

vkucera · 2026-01-12T12:41:57Z

PWGHF/TableProducer/treeCreatorOmegacSt.cxx

            std::array<double, NDaughters> const massesOmegacToOmegaPi{o2::constants::physics::MassOmegaMinus, o2::constants::physics::MassPiPlus};
-            std::array<double, NDaughters> const massesOmegacToOmegaK{o2::constants::physics::MassOmegaMinus, o2::constants::physics::MassKPlus};
-            std::array<double, NDaughters> const massesXicDaughters{o2::constants::physics::MassXiMinus, o2::constants::physics::MassPiPlus};
+            std::array<double, NDaughters> const massOmegaK{o2::constants::physics::MassOmegaMinus, o2::constants::physics::MassKPlus};


Wrong name. This is not a single mass.

vkucera · 2026-01-12T12:43:01Z

PWGHF/TableProducer/treeCreatorOmegacSt.cxx

+                    const bool massOmegacToOmegaPiPass = std::abs(massOmegaPion - o2::constants::physics::MassOmegaC0) < massWindowOmegaC;
+                    const bool massOmegacToOmegaKPass = std::abs(massOmegaKaon - o2::constants::physics::MassOmegaC0) < massWindowOmegaC;
+                    const bool massOmegacToXiPiPass = std::abs(massXiPion - o2::constants::physics::MassOmegaC0) < massWindowOmegaC;
+                    const bool massXicToOmegaKaPass = std::abs(massOmegaKaon - o2::constants::physics::MassXiC0) < massWindowXiC;
+                    const bool massXicToXiPiPass = std::abs(massXiPion - o2::constants::physics::MassXiC0) < massWindowXiC;


These are not masses.

vkucera · 2026-01-12T12:44:03Z

PWGHF/TableProducer/treeCreatorOmegacSt.cxx

+                      case XicToXiPi:
+                        passSelectedChannel = massXicToXiPiPass;
+                        break;
+                      case XicToOmegaKa:
+                        passSelectedChannel = massXicToOmegaKaPass;
+                        break;
+                      case OmegacToOmegaPi:
+                        passSelectedChannel = massOmegacToOmegaPiPass;
+                        break;
+                      case OmegacToOmegaKa:


Why don't you calculate the conditions here (only when needed)?

vkucera · 2026-01-12T12:44:27Z

PWGHF/TableProducer/treeCreatorOmegacSt.cxx

+                    if (cpaCharmedBaryon < cpaCharmedBaryonMin)
+                      continue;
+                    if (cpaXYCharmedBaryon < cpaXYCharmedBaryonMin)
+                      continue;
+                    if (cpaCasc < cpaCascMin)
+                      continue;


Missing braces everywhere.

FDUEnrich and others added 24 commits October 12, 2025 15:07

Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx

13ee65a

Fix a name bug.

Please consider the following formatting changes

a47bf5d

Merge pull request #15 from alibuild/alibot-cleanup-13353

92b4988

[PWGHF] Please consider the following formatting changes to AliceO2Group#13353

Merge branch 'AliceO2Group:master' into master

ed1c34a

Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx

b80f074

Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx

8894f1b

Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx

301059f

Merge branch 'AliceO2Group:master' into master

dc65f2b

Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx

774d6d5

Merge branch 'AliceO2Group:master' into master

65060e8

Merge branch 'AliceO2Group:master' into master

d2c3b29

Merge branch 'AliceO2Group:master' into master

8288b8c

Merge branch 'AliceO2Group:master' into master

b6df99b

Merge branch 'AliceO2Group:master' into master

94ff254

Merge branch 'AliceO2Group:master' into master

daabb0e

Enhance treeCreatorOmegacSt with new mass columns

5d50aa5

Added new mass columns for Omega and Xi particles and updated event selection criteria.

Merge branch 'AliceO2Group:master' into master

898c8f2

Add Centrality estimator, variables calculation and preselection config

c289652

Merge branch 'AliceO2Group:master' into master

0decfa5

Add centrality and preselection

ac5517a

Add Cent and preselection

2788efd

Merge branch 'AliceO2Group:master' into Add-preselection-and-centrali…

14dc656

…ty-to-STTree-creatore

new version

8f07a7c

Merge branch 'AliceO2Group:master' into Add-preselection-and-centrali…

9c8dd4d

…ty-to-STTree-creatore

FDUEnrich requested review from alibuild, fcatalan92, fcolamar, fgrosa, mfaggin and vkucera as code owners December 17, 2025 08:39

Merge pull request #19 from alibuild/alibot-cleanup-14252

1d7cf80

Please consider the following formatting changes to AliceO2Group#14252

vkucera reviewed Dec 19, 2025

View reviewed changes

PWGHF/TableProducer/treeCreatorOmegacSt.cxx Outdated Show resolved Hide resolved

FDUEnrich added 2 commits December 21, 2025 15:54

Merge branch 'AliceO2Group:master' into Add-preselection-and-centrali…

1f4f304

…ty-to-STTree-creatore

Fix name

5cb9ad7

vkucera reviewed Dec 21, 2025

View reviewed changes

PWGHF/TableProducer/treeCreatorOmegacSt.cxx Outdated Show resolved Hide resolved

Replace the magic number.

2dbd4c3

alibuild mentioned this pull request Dec 24, 2025

Please consider the following formatting changes to #14252 FDUEnrich/O2Physics#20

Closed

Refactor CHANNEL_TYPES to enum ChannelType

4ed748f

FDUEnrich marked this pull request as ready for review December 24, 2025 10:23

vkucera reviewed Dec 24, 2025

View reviewed changes

PWGHF/TableProducer/treeCreatorOmegacSt.cxx Show resolved Hide resolved

vkucera marked this pull request as draft December 24, 2025 16:19

fix name

b862c7d

FDUEnrich marked this pull request as ready for review December 26, 2025 06:32

vkucera marked this pull request as draft December 26, 2025 13:11

Modify name following the name convention

9d4f31c

FDUEnrich marked this pull request as ready for review December 29, 2025 13:29

vkucera reviewed Jan 8, 2026

View reviewed changes

PWGHF/TableProducer/treeCreatorOmegacSt.cxx Outdated Show resolved Hide resolved

vkucera reviewed Jan 8, 2026

View reviewed changes

vkucera marked this pull request as draft January 8, 2026 00:36

FDUEnrich added 2 commits January 8, 2026 11:44

Merge branch 'AliceO2Group:master' into Add-preselection-and-centrali…

97c6043

…ty-to-STTree-creatore

Fix logic error

383fe06

Updated variable names for clarity and consistency in the treeCreatorOmegacSt.cxx file. Removed unused histogram for mass Xi + pi.

FDUEnrich marked this pull request as ready for review January 8, 2026 13:43

vkucera marked this pull request as draft January 12, 2026 06:02

vkucera reviewed Jan 12, 2026

View reviewed changes

		{"hMassXiPi", "inv. mass #Xi + #pi;inv. mass (GeV/#it{c}^{2})", {HistType::kTH1D, {{400, 1.5, 3.}}}},
		{"hMassXiPiVsPt", "inv. mass #Xi + #pi;inv. mass (GeV/#it{c}^{2});p_{T} (GeV/#it{c})", {HistType::kTH2D, {{400, 1.5, 3.}, {10, 0., 10.}}}},

		const auto ptCascade = std::hypot(momenta[0][0], momenta[0][1]);
		const auto ptPionOrKaon = std::hypot(momenta[1][0], momenta[1][1]);

[PWGHF] Add preselection and centrality to st tree creator #14252

Are you sure you want to change the base?

[PWGHF] Add preselection and centrality to st tree creator #14252

Conversation

FDUEnrich commented Dec 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alibuild commented Dec 30, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vkucera Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

vkucera Jan 12, 2026 •

edited

Loading