Skip to content

Ctpdev: task for populating BK with ctp config/scalers #14993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lietava wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Ctpdev: task for populating BK with ctp config/scalers #14993

lietava wants to merge 6 commits into from
+208 −2

Conversation

@lietava
Copy link
Contributor

@lietava lietava commented Jan 23, 2026

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@lietava lietava marked this pull request as ready for review January 23, 2026 17:47
@lietava lietava requested a review from a team as a code owner January 23, 2026 17:47
shahor02
shahor02 reviewed Jan 23, 2026
View reviewed changes
Detectors/CTP/workflowScalers/src/ctp-bk-write.cxx Outdated
Comment on lines 90 to 94
std::string filename = vm["input-file"].as<std::string>();
std::ifstream file(filename);
if (!file.is_open()) {
std::cout << "Cannot open file! Using only run:" << run << std::endl;
} else {
Copy link
Collaborator

@shahor02 shahor02 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a special none option for the file-name, but you are not processing it. Perhaps one could skip opening the file in case of the none but produce a fatal if the requested file cannot be opened.

Copy link
Contributor Author

@lietava lietava Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I did it like you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lietava @shahor02