Stop resetenv from crashing; tidy up docs #2055
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to start helping with the documentation. That led to two sets of changes:
resetenvwhich was listed as aTODO. That led to realizing that using this command would always generate a python traceback. The reason for this turns out to be that it is creating a "command" that isNonebecause it is adding a line that is the return value ofsetenv. But that is always None.rezconfig.pysuggests it might. And it has afriendsparameter that isn't used and whose purpose I couldn't guess at.TODOlink for therelease_messagepackage_definition.rstthis.is_packageandthis.is_variantAs an aside, I think that
resetenvshould either be removed, or implemented asrezconfig.pyimplies.