From f7f0293ce575c7d5a41d31033845c403460cc85f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Ingvar=20Dahlgren?= Date: Mon, 24 Nov 2025 10:30:37 +0100 Subject: [PATCH 1/4] more explicit testing of pickling of user defined symbol --- symengine/tests/test_pickling.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/symengine/tests/test_pickling.py b/symengine/tests/test_pickling.py index a51a3251..19afafee 100644 --- a/symengine/tests/test_pickling.py +++ b/symengine/tests/test_pickling.py @@ -31,11 +31,17 @@ def __reduce__(self): def test_pysymbol(): a = MySymbol("hello", attr=1) b = pickle.loads(pickle.dumps(a + 2)) - 2 + c = MySymbol("hello", attr=-1) try: assert a == b + assert type(a) == type(b) + assert a.attr == 1 + assert b.attr == 1 + assert b != c finally: a._unsafe_reset() b._unsafe_reset() + c._unsafe_reset() a = MySymbolBase("hello", attr=1) try: From 66a63b9274d4e65516a05e3409975a7298073d72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Ingvar=20Dahlgren?= Date: Mon, 24 Nov 2025 12:24:05 +0100 Subject: [PATCH 2/4] pickling test correctness --- symengine/tests/test_pickling.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/symengine/tests/test_pickling.py b/symengine/tests/test_pickling.py index 19afafee..cefbbfb6 100644 --- a/symengine/tests/test_pickling.py +++ b/symengine/tests/test_pickling.py @@ -22,8 +22,15 @@ def __eq__(self, other): return False return self.name == other.name and self.attr == other.attr + def __ne__(self, other): + return not (self == other) + + def __hash__(self, other): + return hash((self.__class__.__name__, self.name, self.attr)) + class MySymbol(MySymbolBase): + def __reduce__(self): return (self.__class__, (self.name, self.attr)) From 87ff8a3d3de5f0c9e05921f9c7baf7096f99d441 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Ingvar=20Dahlgren?= Date: Mon, 24 Nov 2025 13:46:25 +0100 Subject: [PATCH 3/4] use first commit from symengine/symengine#2129 --- appveyor.yml | 2 ++ bin/test_symengine_unix.sh | 2 ++ symengine_version.txt | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index cdf0ee1b..1dd4c405 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -74,6 +74,8 @@ install: - set /p commit= Date: Mon, 24 Nov 2025 15:38:36 +0100 Subject: [PATCH 4/4] Use second commit (explicit 1st template arg) --- symengine_version.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/symengine_version.txt b/symengine_version.txt index c6fabd2c..470f7b84 100644 --- a/symengine_version.txt +++ b/symengine_version.txt @@ -1 +1 @@ -b9b11156a76470f0e6998476b2550573efdb5aae +d10ee0be16d25f1e35d5cd31d6ac2788eb426833