From abdf08ca8c5a56ed10969f99ed27604306ede7a9 Mon Sep 17 00:00:00 2001 From: Sebastian Bernauer Date: Tue, 13 Jan 2026 10:32:20 +0100 Subject: [PATCH 1/3] docs: Document StatefulSet should be applied last --- rust/operator-binary/src/superset_controller.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rust/operator-binary/src/superset_controller.rs b/rust/operator-binary/src/superset_controller.rs index 1f3abcb0..af999e29 100644 --- a/rust/operator-binary/src/superset_controller.rs +++ b/rust/operator-binary/src/superset_controller.rs @@ -467,6 +467,9 @@ pub async fn reconcile_superset( .with_context(|_| ApplyRoleGroupConfigSnafu { rolegroup: rolegroup.clone(), })?; + + // Note: The StatefulSet needs to be applied last, so that we don't cause unnecessary Pod + // restarts. See https://github.com/stackabletech/commons-operator/issues/111 for details. ss_cond_builder.add( cluster_resources .add(client, rg_statefulset.clone()) From f1aa50869172a6f3b5887e1de9ae3dd0a7ee9f1a Mon Sep 17 00:00:00 2001 From: Sebastian Bernauer Date: Tue, 13 Jan 2026 10:37:54 +0100 Subject: [PATCH 2/3] Improve message --- rust/operator-binary/src/superset_controller.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rust/operator-binary/src/superset_controller.rs b/rust/operator-binary/src/superset_controller.rs index af999e29..cee0d7e8 100644 --- a/rust/operator-binary/src/superset_controller.rs +++ b/rust/operator-binary/src/superset_controller.rs @@ -468,8 +468,9 @@ pub async fn reconcile_superset( rolegroup: rolegroup.clone(), })?; - // Note: The StatefulSet needs to be applied last, so that we don't cause unnecessary Pod - // restarts. See https://github.com/stackabletech/commons-operator/issues/111 for details. + // Note: The StatefulSet needs to be applied after all ConfigMaps and Secrets it mounts + // to prevent unnecessary Pod restarts. + // See https://github.com/stackabletech/commons-operator/issues/111 for details. ss_cond_builder.add( cluster_resources .add(client, rg_statefulset.clone()) From 89a5f0ded3aa614c858abdf8cdec9f1c3ddf4bbe Mon Sep 17 00:00:00 2001 From: Sebastian Bernauer Date: Tue, 13 Jan 2026 10:46:43 +0100 Subject: [PATCH 3/3] Add generation assertion to smoke test --- tests/templates/kuttl/smoke/30-assert.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/templates/kuttl/smoke/30-assert.yaml b/tests/templates/kuttl/smoke/30-assert.yaml index 003e009a..e86d19ff 100644 --- a/tests/templates/kuttl/smoke/30-assert.yaml +++ b/tests/templates/kuttl/smoke/30-assert.yaml @@ -11,6 +11,7 @@ apiVersion: apps/v1 kind: StatefulSet metadata: name: superset-node-default + generation: 1 # There should be no unneeded Pod restarts spec: template: spec: